Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable all node flaky test, move node performance test to new job #23147

Merged
merged 1 commit into from
Aug 11, 2021
Merged

re-enable all node flaky test, move node performance test to new job #23147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion config/jobs/kubernetes/sig-node/node-kubelet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ periodics:
- --deployment=node
- --gcp-project-type=node-e2e-project
- --gcp-zone=us-west1-b
- --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/perf-image-config.yaml
- --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/image-config.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, this is why perf tests were executing:

test-infra/jobs/e2e_node/perf-image-config.yaml

Lines 8 to 9 in caeaace

tests:
- 'Node Performance Testing'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh got it! thanks a lot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very illogical.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the internal config pointed to Node Performance Testing. Something that I should have gone down a level deeper.

- --node-test-args= --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/" --server-start-timeout=420s
- --node-tests=true
- --provider=gce
Expand Down Expand Up @@ -531,3 +531,33 @@ periodics:
testgrid-tab-name: kubelet-gce-e2e-swap-fedora
testgrid-alert-email: ehashman@redhat.com, ikema@google.com
description: Executes E2E suite with swap enabled on Fedora

- name: ci-kubernetes-node-kubelet-performance-test
interval: 12h
labels:
preset-service-account: "true"
preset-k8s-ssh: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/kubekins-e2e:v20210721-2b77449-master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the image; compared to previous PR

args:
- --repo=k8s.io/kubernetes=master
- --timeout=90
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these timeouts make sense? These tests are failing consistently but I don't know if that has anything to do with the runtime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not have timeouts when tests start passing to make sure that they do not take forever. I think it might be better to let them fail after a time regardless, I do not know what the correct value is though.

- --root=/go/src
- --scenario=kubernetes_e2e
- --
- --deployment=node
- --gcp-project-type=node-e2e-project
- --gcp-zone=us-west1-b
- --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/perf-image-config.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use the perf-image-config do we need to specify the focus below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we do not, thanks for catching that.

- --node-test-args= --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/" --server-start-timeout=420s
- --node-tests=true
- --provider=gce
- --test_args=--nodes=1
- --timeout=60m
env:
- name: GOPATH
value: /go
annotations:
testgrid-dashboards: sig-node-kubelet
testgrid-tab-name: node-performance-test