-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable all node flaky test, move node performance test to new job #23147
Conversation
Welcome @manugupt1! |
Hi @manugupt1. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @SergeyKanzhelev |
preset-k8s-ssh: "true" | ||
spec: | ||
containers: | ||
- image: gcr.io/k8s-testimages/kubekins-e2e:v20210721-2b77449-master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the image; compared to previous PR
/ok-to-test |
@@ -126,7 +126,7 @@ periodics: | |||
- --deployment=node | |||
- --gcp-project-type=node-e2e-project | |||
- --gcp-zone=us-west1-b | |||
- --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/perf-image-config.yaml | |||
- --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/image-config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, this is why perf tests were executing:
test-infra/jobs/e2e_node/perf-image-config.yaml
Lines 8 to 9 in caeaace
tests: | |
- 'Node Performance Testing' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh got it! thanks a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very illogical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the internal config pointed to Node Performance Testing
. Something that I should have gone down a level deeper.
/assign @mrunalp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with merging this and finding out for the perf test stuff but let's fix the names.
@@ -531,3 +531,33 @@ periodics: | |||
testgrid-tab-name: kubelet-gce-e2e-swap-fedora | |||
testgrid-alert-email: ehashman@redhat.com, ikema@google.com | |||
description: Executes E2E suite with swap enabled on Fedora | |||
|
|||
- name: ci-kubernetes-node-kubelet-node-performance-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: ci-kubernetes-node-kubelet-node-performance-test | |
- name: ci-kubernetes-node-kubelet-performance-test |
value: /go | ||
annotations: | ||
testgrid-dashboards: sig-node-kubelet | ||
testgrid-tab-name: node-performance-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testgrid-tab-name: node-performance-testing | |
testgrid-tab-name: node-performance-test |
- image: gcr.io/k8s-testimages/kubekins-e2e:v20210721-2b77449-master | ||
args: | ||
- --repo=k8s.io/kubernetes=master | ||
- --timeout=90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these timeouts make sense? These tests are failing consistently but I don't know if that has anything to do with the runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not have timeouts when tests start passing to make sure that they do not take forever. I think it might be better to let them fail after a time regardless, I do not know what the correct value is though.
- --deployment=node | ||
- --gcp-project-type=node-e2e-project | ||
- --gcp-zone=us-west1-b | ||
- --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/perf-image-config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use the perf-image-config do we need to specify the focus below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we do not, thanks for catching that.
- --node-test-args= --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/" --server-start-timeout=420s | ||
- --node-tests=true | ||
- --provider=gce | ||
- --test_args=--nodes=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a stray "
- --test_args=--nodes=1" | |
- --test_args=--nodes=1 |
From: kubernetes#19352 Filtering of test runs in perf-image-config.yaml means only specific tests matching "Node Performance Testing" run in flaky job. Move flaky test job back to general image-config.yaml. Create new job config specific to "Node Performance Testing". Decrease ci interval of new "Node Performance Testing" job to 12h instead of 2h.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, manugupt1, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@manugupt1: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From: #19352
Filtering of test runs in perf-image-config.yaml means only specific
tests matching "Node Performance Testing" run in flaky job.
Move flaky test job back to general image-config.yaml.
Create new job config specific to "Node Performance Testing".
Decrease ci interval of new "Node Performance Testing" job to 12h
instead of 2h.
Note: I was not able to check if the dashboard was created or not.