-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HNC postsubmits and periodics #20773
Conversation
Hi @adrianludwin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This replaces #19856 |
fec760f
to
e684b97
Compare
Giving this a shot :) /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
3 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
e684b97
to
1ec3c88
Compare
/retest |
b4a8795
to
b5bfa8d
Compare
b5bfa8d
to
2a13c2e
Compare
Run HNC's end-to-end tests in a Kind cluster, using a custom-built image defined in https://github.com/kubernetes-sigs/multi-tenancy/tree/master/incubator/hnc/hack/prow-e2e. Note that I've set the periodics to run every 12h; this is temporary until we've seen a few passing runs. After that point, I'll reduce the frequency to 48h (i.e. every two days). Tested: on my local workstation, the custom-built image successfully runs the latest e2e tests on Kind following the instructions in the HNC repo (see README at the link above). I have no way to test that the Prow configs are correct as we've cobbled them together from other tests' examples.
2a13c2e
to
c4b5fcc
Compare
/cc @rjbez17 Looks like I've fixed all the presubmits now, can you please re-lgtm? Thanks! |
/lgtm Nice work! |
@adrianludwin: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Run HNC's end-to-end tests in a Kind cluster, using a custom-built image
defined in
https://github.com/kubernetes-sigs/multi-tenancy/tree/master/incubator/hnc/hack/prow-e2e.
Note that I've set the periodics to run every 12h; this is temporary
until we've seen a few passing runs. After that point, I'll reduce the
frequency to 48h (i.e. every two days).
Tested: on my local workstation, the custom-built image successfully
runs the latest e2e tests on Kind following the instructions in the HNC
repo (see README at the link above). I have no way to test that the Prow
configs are correct as we've cobbled them together from other tests'
examples.