Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HNC postsubmits and periodics #20773

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

adrianludwin
Copy link
Contributor

Run HNC's end-to-end tests in a Kind cluster, using a custom-built image
defined in
https://github.com/kubernetes-sigs/multi-tenancy/tree/master/incubator/hnc/hack/prow-e2e.

Note that I've set the periodics to run every 12h; this is temporary
until we've seen a few passing runs. After that point, I'll reduce the
frequency to 48h (i.e. every two days).

Tested: on my local workstation, the custom-built image successfully
runs the latest e2e tests on Kind following the instructions in the HNC
repo (see README at the link above). I have no way to test that the Prow
configs are correct as we've cobbled them together from other tests'
examples.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @adrianludwin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2021
@adrianludwin
Copy link
Contributor Author

This replaces #19856

@rjbez17
Copy link
Contributor

rjbez17 commented Feb 12, 2021

Giving this a shot :)

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2021
@adrianludwin
Copy link
Contributor Author

/retest

@adrianludwin adrianludwin force-pushed the hnc-postsubmits branch 4 times, most recently from b4a8795 to b5bfa8d Compare February 13, 2021 03:50
Run HNC's end-to-end tests in a Kind cluster, using a custom-built image
defined in
https://github.com/kubernetes-sigs/multi-tenancy/tree/master/incubator/hnc/hack/prow-e2e.

Note that I've set the periodics to run every 12h; this is temporary
until we've seen a few passing runs. After that point, I'll reduce the
frequency to 48h (i.e. every two days).

Tested: on my local workstation, the custom-built image successfully
runs the latest e2e tests on Kind following the instructions in the HNC
repo (see README at the link above). I have no way to test that the Prow
configs are correct as we've cobbled them together from other tests'
examples.
@adrianludwin
Copy link
Contributor Author

/cc @rjbez17

Looks like I've fixed all the presubmits now, can you please re-lgtm? Thanks!

@rjbez17
Copy link
Contributor

rjbez17 commented Feb 13, 2021

/lgtm

Nice work!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit d34feb5 into kubernetes:master Feb 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 13, 2021
@k8s-ci-robot
Copy link
Contributor

@adrianludwin: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key hnc-e2e.yaml using file config/jobs/kubernetes-sigs/wg-multi-tenancy/hnc-e2e.yaml

In response to this:

Run HNC's end-to-end tests in a Kind cluster, using a custom-built image
defined in
https://github.com/kubernetes-sigs/multi-tenancy/tree/master/incubator/hnc/hack/prow-e2e.

Note that I've set the periodics to run every 12h; this is temporary
until we've seen a few passing runs. After that point, I'll reduce the
frequency to 48h (i.e. every two days).

Tested: on my local workstation, the custom-built image successfully
runs the latest e2e tests on Kind following the instructions in the HNC
repo (see README at the link above). I have no way to test that the Prow
configs are correct as we've cobbled them together from other tests'
examples.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adrianludwin adrianludwin deleted the hnc-postsubmits branch February 18, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants