-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure post-submit test for HNC #19856
Conversation
Hi @GinnyJI. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @BenTheElder |
@GinnyJI: GitHub didn't allow me to request PR reviews from the following users: adrianludwin. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all lgtm but I don't know the technical details at all. But it does seem to express how we in wg-multitenancy want this to run!
@adrianludwin: GitHub didn't allow me to assign the following users: rjbez217. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rjbez17 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GinnyJI, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
4 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
New changes are detected. LGTM label has been removed. |
b008347
to
5291faf
Compare
config/jobs/kubernetes-sigs/wg-multi-tenancy/hnc-postsubmit.yaml
Outdated
Show resolved
Hide resolved
Note: this changed has not been tested, I don't know how to test it. If this change break then post-submit tests for HNC will simply not run, but developers can still merge in their changes because it's not supposed to affect pre-submit tests.
lgtm, let's wait until the script has been submitted in our repo and then Ryan or Tasha can approve this. |
/test pull-test-infra-integration |
Ginny and I just started working on this again last week - hopefully we'll have something to submit ~soon. |
Ok, we've submitted and tested the new script locally (kubernetes-retired/multi-tenancy#1369). I suspect I'll want to create a new PR based off of this one instead of trying to reuse it; I'll close this PR if I do. |
@adrianludwin @GinnyJI now that we kubernetes-retired/multi-tenancy#1369 merged, are we ready to come back to this? Did you want to create a new PR or keep this one? |
I think I'll create a new PR. I'll get to it later this week (Friday is
usually my HNC coding day these days!)
…On Wed, Feb 3, 2021 at 10:31 AM Ryan Bezdicek ***@***.***> wrote:
@adrianludwin <https://github.com/adrianludwin> @GinnyJI
<https://github.com/GinnyJI> now that we
kubernetes-retired/multi-tenancy#1369
<kubernetes-retired/multi-tenancy#1369> merged, are
we ready to come back to this? Did you want to create a new PR or keep this
one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19856 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE43PZFYPYNWOVMXZBUZGELS5FT6ZANCNFSM4TLPCYWQ>
.
|
/close Replaced by #20773 |
@adrianludwin: You can't close an active issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@GinnyJI can you please close this issue? |
/close |
@GinnyJI: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Note: this changed has not been tested, I don't know how to test it. If
this change break then post-submit tests for HNC will simply not run,
but developers can still merge in their changes because it's not
supposed to affect pre-submit tests.
Here's what I referenced for this change:
test-infra/config/jobs/kubernetes/sig-network/ingress-nginx.yaml
Lines 166 to 195 in 9b4e473