Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure post-submit test for HNC #19856

Closed
wants to merge 1 commit into from

Conversation

GinnyJI
Copy link

@GinnyJI GinnyJI commented Nov 5, 2020

Note: this changed has not been tested, I don't know how to test it. If
this change break then post-submit tests for HNC will simply not run,
but developers can still merge in their changes because it's not
supposed to affect pre-submit tests.

Here's what I referenced for this change:

- name: pull-ingress-nginx-e2e-1-15
always_run: false
decorate: true
decoration_config:
timeout: 1h
max_concurrency: 5
path_alias: k8s.io/ingress-nginx
#run_if_changed: '\.go$|^rootfs/'
labels:
preset-kind-volume-mounts: "true"
preset-dind-enabled: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/krte:v20200824-5d057db-master
command:
- wrapper.sh
- bash
- -c
- curl -sSL https://kind.sigs.k8s.io/dl/latest/linux-amd64.tgz | tar xvfz - -C "${PATH%%:*}/" && make kind-e2e-test
# docker-in-docker needs privileged mode
securityContext:
privileged: true
env:
- name: REPO_INFO
value: https://github.com/kubernetes/ingress-nginx
- name: K8S_VERSION
value: v1.15.11@sha256:6cc31f3533deb138792db2c7d1ffc36f7456a06f1db5556ad3b6927641016f50
annotations:
testgrid-dashboards: sig-network-ingress-nginx
testgrid-tab-name: e2e-1-15

@k8s-ci-robot
Copy link
Contributor

Hi @GinnyJI. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 5, 2020
@GinnyJI
Copy link
Author

GinnyJI commented Nov 5, 2020

/assign @BenTheElder
/cc @adrianludwin

@k8s-ci-robot
Copy link
Contributor

@GinnyJI: GitHub didn't allow me to request PR reviews from the following users: adrianludwin.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @BenTheElder
/cc @adrianludwin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all lgtm but I don't know the technical details at all. But it does seem to express how we in wg-multitenancy want this to run!

@adrianludwin
Copy link
Contributor

adrianludwin commented Nov 13, 2020

Ben's not going to be able to have a look. Tasha, Sanjeev, Ryan - it looks like you have the ability to approve in this directory?

/assign @tashimi
/assign @srampal

@k8s-ci-robot
Copy link
Contributor

@adrianludwin: GitHub didn't allow me to assign the following users: rjbez217.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Ben's not going to be able to have a look. Tasha, Sanjeev, Ryan - it looks like you have the ability to approve in this directory?

/assign @tashimi
/assign @rjbez217
/assign @srampal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adrianludwin
Copy link
Contributor

/assign @rjbez17

@rjbez17
Copy link
Contributor

rjbez17 commented Nov 13, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GinnyJI, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@rjbez17
Copy link
Contributor

rjbez17 commented Nov 13, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@GinnyJI GinnyJI force-pushed the postsubmit branch 2 times, most recently from b008347 to 5291faf Compare November 13, 2020 18:11
Note: this changed has not been tested, I don't know how to test it. If
this change break then post-submit tests for HNC will simply not run,
but developers can still merge in their changes because it's not
supposed to affect pre-submit tests.
@adrianludwin
Copy link
Contributor

lgtm, let's wait until the script has been submitted in our repo and then Ryan or Tasha can approve this.

@spiffxp
Copy link
Member

spiffxp commented Jan 19, 2021

/test pull-test-infra-integration
#20498 (comment)

@adrianludwin
Copy link
Contributor

Ginny and I just started working on this again last week - hopefully we'll have something to submit ~soon.

@adrianludwin
Copy link
Contributor

Ok, we've submitted and tested the new script locally (kubernetes-retired/multi-tenancy#1369). I suspect I'll want to create a new PR based off of this one instead of trying to reuse it; I'll close this PR if I do.

@BenTheElder BenTheElder removed their assignment Feb 1, 2021
@rjbez17
Copy link
Contributor

rjbez17 commented Feb 3, 2021

@adrianludwin @GinnyJI now that we kubernetes-retired/multi-tenancy#1369 merged, are we ready to come back to this? Did you want to create a new PR or keep this one?

@adrianludwin
Copy link
Contributor

adrianludwin commented Feb 3, 2021 via email

@adrianludwin
Copy link
Contributor

/close

Replaced by #20773

@k8s-ci-robot
Copy link
Contributor

@adrianludwin: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Replaced by #20773

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adrianludwin
Copy link
Contributor

@GinnyJI can you please close this issue?

@GinnyJI
Copy link
Author

GinnyJI commented Feb 8, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@GinnyJI: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants