Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable blockade for design-proposals #17137

Merged

Conversation

mrbobbytables
Copy link
Member

Design proposals have been deprecated for some time now -- However this hasn't stopped folks from opening PRs to update them that often flounder (ref: kubernetes/community#4627, ref: kubernetes/community#4317), or open a PR to add features (ref: kubernetes/community#3890).

With that I think it'd be a good idea to just nip it in the bud for now till their eventual migration to the k/enhancements repo for archival.

/cc @justaugustus @cblecker @nikhita

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 7, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 7, 2020

/approve
completely agree, leaving /lgtm to one of the reviewers

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@justaugustus
Copy link
Member

Agreed and overdue (mea culpa)!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, mrbobbytables, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2ac9863 into kubernetes:master Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Updated the plugins configmap in namespace default at cluster default using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Design proposals have been deprecated for some time now -- However this hasn't stopped folks from opening PRs to update them that often flounder (ref: kubernetes/community#4627, ref: kubernetes/community#4317), or open a PR to add features (ref: kubernetes/community#3890).

With that I think it'd be a good idea to just nip it in the bud for now till their eventual migration to the k/enhancements repo for archival.

/cc @justaugustus @cblecker @nikhita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants