Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of OOM score configuration section in resource-qos.md #4317

Closed
wants to merge 1 commit into from

Conversation

Jonnymcc
Copy link

@Jonnymcc Jonnymcc commented Dec 13, 2019

Two things were confusing to me in this section.

  1. "The base OOM score is between 0 and 1000, so if process A's OOM_SCORE_ADJ - process B's OOM_SCORE_ADJ is over a 1000, then process A will always be OOM killed before B."
    This implies that both A and B have the same base score? And could it be simplified to say if A's OOM_SCORE_ADJ > B, then A will be killed. And this would also apply to the final OOM score, if this is saying they both have the same base OOM score.
  2. Pods, containers, and processes are mixed into a bunch of these rules and it's not super clear in each rule which one the OOM score applies to.

Examples:

  • The final OOM score of a process is also between 0 and 1000. (process)
  • If a burstable pod uses less memory than requested, then its OOM_SCORE < 1000 (pod)
  • Pod infra containers or Special Pod init process (containers?)

Two things were confusing to me in this section.
1. "The base OOM score is between 0 and 1000, so if process A's OOM_SCORE_ADJ - process B's OOM_SCORE_ADJ is over a 1000, then process A will always be OOM killed before B."
This implies that both A and B have the same base score? And could it be simplified to say if A's OOM_SCORE_ADJ > B, than A will be killed. And this would also apply to the final OOM score, if this is saying they both have the same base OOM score.
2. Pods, containers, and processes are mixed into a bunch of these rules and it's not super clear in each rule which one the OOM score applies to.
Ex.
- The final OOM score of a process is also between 0 and 1000. (process)
- If a burstable pod uses less memory than requested, then its OOM_SCORE < 1000 (pod)
- Pod infra containers or Special Pod init process (containers?)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @Jonnymcc!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Jonnymcc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jonnymcc
To complete the pull request process, please assign dchen1107
You can assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/design Categorizes issue or PR as related to design. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Dec 13, 2019
@Jonnymcc
Copy link
Author

/assign dchen1107

@mrbobbytables
Copy link
Member

@Jonnymcc I know this is a formatting fix -- but for the most part design proposals are there for historic/archival purposes and not updated.

They're going to be migrated in the near future to exist alongside their replacement (Kubernetes Enhancement Proposals). We can leave this open for a bit longer, but we'll be closing out all PRs later this month that touch the design proposals in preparation for their migration.

@mrbobbytables
Copy link
Member

@Jonnymcc thanks for your PR, but at this time we're no longer going to be accepting updates to design-proposals as they're flagged for archival and will soon be moved out of the repo.

With that I'm going to go ahead and close this PR. If you have questions, please feel free to ping me here or in slack.

Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closed this PR.

In response to this:

@Jonnymcc thanks for your PR, but at this time we're no longer going to be accepting updates to design-proposals as they're flagged for archival and will soon be moved out of the repo.

With that I'm going to go ahead and close this PR. If you have questions, please feel free to ping me here or in slack.

Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants