-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting of OOM score configuration section in resource-qos.md #4317
Conversation
Two things were confusing to me in this section. 1. "The base OOM score is between 0 and 1000, so if process A's OOM_SCORE_ADJ - process B's OOM_SCORE_ADJ is over a 1000, then process A will always be OOM killed before B." This implies that both A and B have the same base score? And could it be simplified to say if A's OOM_SCORE_ADJ > B, than A will be killed. And this would also apply to the final OOM score, if this is saying they both have the same base OOM score. 2. Pods, containers, and processes are mixed into a bunch of these rules and it's not super clear in each rule which one the OOM score applies to. Ex. - The final OOM score of a process is also between 0 and 1000. (process) - If a burstable pod uses less memory than requested, then its OOM_SCORE < 1000 (pod) - Pod infra containers or Special Pod init process (containers?)
Welcome @Jonnymcc! |
Hi @Jonnymcc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jonnymcc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign dchen1107 |
@Jonnymcc I know this is a formatting fix -- but for the most part design proposals are there for historic/archival purposes and not updated. They're going to be migrated in the near future to exist alongside their replacement (Kubernetes Enhancement Proposals). We can leave this open for a bit longer, but we'll be closing out all PRs later this month that touch the design proposals in preparation for their migration. |
@Jonnymcc thanks for your PR, but at this time we're no longer going to be accepting updates to design-proposals as they're flagged for archival and will soon be moved out of the repo. With that I'm going to go ahead and close this PR. If you have questions, please feel free to ping me here or in slack. Thanks! /close |
@mrbobbytables: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Two things were confusing to me in this section.
This implies that both A and B have the same base score? And could it be simplified to say if A's OOM_SCORE_ADJ > B, then A will be killed. And this would also apply to the final OOM score, if this is saying they both have the same base OOM score.
Examples: