Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload new image for prow jobs with bazel 0.23.2 #11751

Merged

Conversation

smukherj1
Copy link
Contributor

Blocking bazelbuild/rules_k8s#289 and
bazelbuild/rules_k8s#280 which need newer Bazel
version. Currently the image used by prow has Bazel 0.22.0

Blocking bazelbuild/rules_k8s#289 and
bazelbuild/rules_k8s#280 which need newer Bazel
version. Currently the image used by prow has Bazel 0.22.0
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @smukherj1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2019
@fejta
Copy link
Contributor

fejta commented Mar 13, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3d9e05dbe77b30139b16b6f151eb5a98efdc908a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@stevekuznetsov
Copy link
Contributor

Do we want to bump the required version in the same action?

@smukherj1
Copy link
Contributor Author

@stevekuznetsov I'm not sure what that means. Could you explain where in the config this is specified or are you referring to something else?

@fejta
Copy link
Contributor

fejta commented Mar 14, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2019
@fejta
Copy link
Contributor

fejta commented Mar 14, 2019

It's specified in your repos WORKSPACE file.

See https://github.com/kubernetes/test-infra/blob/master/WORKSPACE#L14 for our repo.

That PR would be in your repo so therefore obviously not a part of this PR

@k8s-ci-robot k8s-ci-robot merged commit 103b676 into kubernetes:master Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

@smukherj1: Updated the job-config configmap in namespace default using the following files:

  • key rules_k8s_config.yaml using file config/jobs/bazelbuild/rules_k8s/rules_k8s_config.yaml

In response to this:

Blocking bazelbuild/rules_k8s#289 and
bazelbuild/rules_k8s#280 which need newer Bazel
version. Currently the image used by prow has Bazel 0.22.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants