Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Update deps for --incompatible_remove_old_python_version_api #289

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Update deps for --incompatible_remove_old_python_version_api #289

merged 2 commits into from
Mar 15, 2019

Conversation

brandjon
Copy link
Member

This moves the explicit rules_python dep up in the WORKSPACE file so it takes precedence. It also adds an explicit dep on subpar to override transitive deps on it that have yet to be updated.

… 0.23

This moves the explicit rules_python dep up in the WORKSPACE file so it takes precedence. It also adds an explicit dep on subpar to override transitive deps on it that have yet to be updated.
@brandjon
Copy link
Member Author

The error message indicates that your CI is using an older version of Bazel. This PR updates for an incompatible change flag added by Bazel 0.23, which will become flipped (i.e., actually breaking) in Bazel 0.25. The update requires features added by Bazel 0.23, hence why CI is failing.

@smukherj1
Copy link
Contributor

Alright I'll look into updating the Bazel version in our CI image. There's another renovate update PR that's failing because of this

smukherj1 added a commit to smukherj1/test-infra that referenced this pull request Mar 13, 2019
Blocking bazelbuild/rules_k8s#289 and
bazelbuild/rules_k8s#280 which need newer Bazel
version. Currently the image used by prow has Bazel 0.22.0
@smukherj1
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brandjon, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants