Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split e2e test with sample test #11200

Merged
merged 2 commits into from
Feb 9, 2019
Merged

split e2e test with sample test #11200

merged 2 commits into from
Feb 9, 2019

Conversation

IronPan
Copy link
Contributor

@IronPan IronPan commented Feb 8, 2019

This is part 2 of the test split
for context see kubeflow/pipelines#799

@IronPan
split e2e test with sample test
4abf455 
This is part 2 of the test split
for context see kubeflow/pipelines#799
@k8s-ci-robot
Copy link
Contributor

Hi @IronPan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 8, 2019
@IronPan
Copy link
Contributor Author

IronPan commented Feb 8, 2019

/assign @gaoning777 @krzyzacy

@k8s-ci-robot
Copy link
Contributor

@IronPan: GitHub didn't allow me to assign the following users: gaoning777.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gaoning777 @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Contributor Author

IronPan commented Feb 8, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2019
@IronPan
Copy link
Contributor Author

IronPan commented Feb 8, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2019
krzyzacy
krzyzacy reviewed Feb 8, 2019
View reviewed changes
config/jobs/kubeflow/kubeflow-presubmits.yaml Outdated
- name: kubeflow-pipeline-sample-test
image: gcr.io/k8s-testimages/kubekins-e2e:v20190205-d83780367-1.10

kubeflow/pipelines:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the extra kubeflow/pipelines key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2019
krzyzacy
krzyzacy approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c734b7cb980d7c6a24e247a35920fc3603a7c9c7

@krzyzacy
Copy link
Member

krzyzacy commented Feb 8, 2019

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2019
@IronPan
Copy link
Contributor Author

IronPan commented Feb 8, 2019

tests seems hanging.

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

/retest

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

/meow

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

hummmmmm?!

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: https://thecatapi.com appears to be down

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

/retest

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

/woof

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

/pony fine

@IronPan
Copy link
Contributor Author

IronPan commented Feb 9, 2019

/test pull-test-infra-bazel

@IronPan
Copy link
Contributor Author

IronPan commented Feb 9, 2019

/test pull-test-infra-verify-bazel

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: pony image

In response to this:

/pony fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@gaoning777: changing LGTM is restricted to assignees, and only kubernetes/test-infra repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Contributor Author

IronPan commented Feb 9, 2019

/retest

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

/test pull-test-infra-bazel

@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy krzyzacy reopened this Feb 9, 2019
@krzyzacy
Copy link
Member

krzyzacy commented Feb 9, 2019

/skip

@k8s-ci-robot k8s-ci-robot merged commit f349837 into kubernetes:master Feb 9, 2019
@k8s-ci-robot
Copy link
Contributor

@IronPan: Updated the job-config configmap using the following files:

  • key kubeflow-presubmits.yaml using file config/jobs/kubeflow/kubeflow-presubmits.yaml

In response to this:

This is part 2 of the test split
for context see kubeflow/pipelines#799

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy approved these changes

@jlewi jlewi Awaiting requested review from jlewi

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IronPan @k8s-ci-robot @krzyzacy @gaoning777