Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge build image to test suit #799

Merged
merged 10 commits into from
Feb 9, 2019
Merged

merge build image to test suit #799

merged 10 commits into from
Feb 9, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Feb 8, 2019

Due to kubernetes/test-infra#11197
we need to move build image step to individual test suit.

Steps:


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Feb 8, 2019

/assign @gaoning777

@IronPan
Copy link
Member Author

IronPan commented Feb 8, 2019

cc @krzyzacy

@krzyzacy
Copy link

krzyzacy commented Feb 8, 2019

Do you want to split up the unified job into multiple jobs then?

@IronPan
Copy link
Member Author

IronPan commented Feb 8, 2019

@krzyzacy yup that's the plan. please check pr description see if i miss anything.

@gaoning777
Copy link
Contributor

/lgtm

IronPan added a commit to IronPan/test-infra that referenced this pull request Feb 8, 2019
This is part 2 of the test split
for context see kubeflow/pipelines#799
@IronPan
Copy link
Member Author

IronPan commented Feb 8, 2019

/test kubeflow-pipeline-presubmit

@IronPan
Copy link
Member Author

IronPan commented Feb 8, 2019

/retest

@krzyzacy
Copy link

krzyzacy commented Feb 8, 2019

maybe close/reopen the PR to get a clearer state?

@IronPan IronPan closed this Feb 8, 2019
@IronPan IronPan reopened this Feb 8, 2019
@IronPan
Copy link
Member Author

IronPan commented Feb 8, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@IronPan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@IronPan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 9, 2019
@IronPan
Copy link
Member Author

IronPan commented Feb 9, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 9, 2019

@IronPan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-presubmit 2082528 link /test kubeflow-pipeline-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krzyzacy
Copy link

krzyzacy commented Feb 9, 2019

/lgtm

@krzyzacy
Copy link

krzyzacy commented Feb 9, 2019

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Feb 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan IronPan merged commit e9bd7c6 into kubeflow:master Feb 9, 2019
midnightconman pushed a commit to midnightconman/test-infra that referenced this pull request Feb 16, 2019
This is part 2 of the test split
for context see kubeflow/pipelines#799
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* test: fix cleanup blueprints script

* fix2

* fix3

* fix Makefile, update ACM repo, add dryrun=false
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants