Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Kubernetes-CSI image publishing #13332

Closed
pohly opened this issue Jul 5, 2019 · 13 comments
Closed

enable Kubernetes-CSI image publishing #13332

pohly opened this issue Jul 5, 2019 · 13 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@pohly
Copy link
Contributor

pohly commented Jul 5, 2019

What would you like to be added:

As part of kubernetes/k8s.io#158, gcr.io/k8s-staging-csi was created (kubernetes/k8s.io#158 (comment)). What we need now are credentials in a secret that the Kubernetes-CSI Prow jobs (https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-csi) can use to actually push images into that staging area.

Why is this needed:

Currently, images are still being pushed into quay.io from TravisCI while only testing happens in Prow. We want to move entirely to Prow.

@pohly pohly added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 5, 2019
@detiber
Copy link
Member

detiber commented Jul 5, 2019

/cc
watching since we'd like to do something similar for cluster-api

@amy
Copy link

amy commented Jul 15, 2019

See slack convo here: https://kubernetes.slack.com/archives/CCK68P2Q2/p1563199619408300?thread_ts=1562332672.163800&cid=CCK68P2Q2

Summary: wg-k8s-infra is onboarding cluster-api as a guinea pig for the promotion process and waiting to see how their adoption goes.

@rajibmitra
Copy link
Member

I would love to work on "credentials in a secret" part if no one is working on it currently.

@detiber
Copy link
Member

detiber commented Sep 10, 2019

Following up on this thread, there has been work on this area by @Katharine and @thockin to enable GCB builds from Prow.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2019
@msau42
Copy link
Member

msau42 commented Dec 12, 2019

/cc
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 12, 2019
@pohly
Copy link
Contributor Author

pohly commented Mar 5, 2020

Some more documentation has been added on how to do this:

The question also came up whether "docker buildx" for multiple target architectures can be done there, which is a new requirement (kubernetes-csi/node-driver-registrar#63). So far the answer is "maybe" (kubernetes-csi/node-driver-registrar#63 (comment)).

@BenTheElder
Copy link
Member

BenTheElder commented Apr 22, 2020

Docker buildx should work fine in GCB or prow.

please do not set qemu / multi-arch / binfmt_misc on prow, as binfmt_misc is kernel global. setting it up on GCB is fine, the underlying VM is disposed after your build.

@dims
Copy link
Member

dims commented Apr 22, 2020

almost there getting the docker buildx in cloudbuild.yaml in https://github.com/kubernetes-csi/node-driver-registrar to work. still needs kubernetes-csi/node-driver-registrar#76 to merge

@pohly
Copy link
Contributor Author

pohly commented May 27, 2020

Discussion continues in kubernetes-csi/csi-release-tools#86

@BenTheElder
Copy link
Member

I think this was done? Poke.

@pohly
Copy link
Contributor Author

pohly commented Aug 28, 2020

Yes. We are keeping that csi-release-tools issue open because we also started tracking multi-architecture image publishing which still needs to be done for some sidecars, but as far as test-infra is concerned, everything is working.

/close

@k8s-ci-robot
Copy link
Contributor

@pohly: Closing this issue.

In response to this:

Yes. We are keeping that csi-release-tools issue open because we also started tracking multi-architecture image publishing which still needs to be done for some sidecars, but as far as test-infra is concerned, everything is working.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

9 participants