Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish images from master after each merge #1145

Closed
vincepri opened this issue Jul 11, 2019 · 7 comments · Fixed by #1327
Closed

Publish images from master after each merge #1145

vincepri opened this issue Jul 11, 2019 · 7 comments · Fixed by #1327
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@vincepri
Copy link
Member

/kind feature

Describe the solution you'd like
We should have a way to automatically push a new master image to the staging bucket after each PR is merged to ease development, the images should be tagged and pushed with :master and :<commit-hash>.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 11, 2019
@detiber
Copy link
Member

detiber commented Jul 11, 2019

There is an upstream issue for doing this for the kubernetes-csi artifacts that may help with implementing this: kubernetes/test-infra#13332

@amy
Copy link
Contributor

amy commented Jul 15, 2019

From slack:

jdetiber  [7 minutes ago]
I was actually tracking @pohly's issue because we would like to create a prow job for cluster-api that automatically updates a `latest` tag as a postsubmit job to `master` :joy:

spiffxp  [7 minutes ago]
what we use for test-infra is https://github.com/kubernetes/test-infra/tree/master/images/builder

spiffxp  [7 minutes ago]
so maybe it’s worth asking @Katharine what it would take to make that reusable for other repos (I believe it is also used for kubernetes-sigs/slack-infra)

jdetiber  [6 minutes ago]
At least for the staging image, we're not necessarily looking to automate release images at this point, though

spiffxp  [6 minutes ago]
we build/push on merge, and then have separate PRs to update manifests using the new image

jdetiber  [6 minutes ago]
That would definitely work for us

spiffxp  [5 minutes ago]
the “catch” is that it’s via cloudbuild, but there a variety of images in https://github.com/kubernetes/test-infra/tree/master/images that get along fine with that model

https://kubernetes.slack.com/archives/CCK68P2Q2/p1563209559416100?thread_ts=1562332672.163800&cid=CCK68P2Q2

@ncdc ncdc added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 17, 2019
@ncdc ncdc added this to the Next milestone Jul 17, 2019
@ncdc ncdc removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 17, 2019
@ncdc ncdc modified the milestones: Next, v1alpha2 Jul 17, 2019
@detiber
Copy link
Member

detiber commented Aug 28, 2019

/reopen

This will not be resolved until we are able to get a service account from wg-k8s-infra

@k8s-ci-robot
Copy link
Contributor

@detiber: Reopened this issue.

In response to this:

/reopen

This will not be resolved until we are able to get a service account from wg-k8s-infra

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Aug 28, 2019
@detiber detiber added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 28, 2019
@vincepri vincepri self-assigned this Aug 28, 2019
@ncdc ncdc added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 4, 2019
@vincepri
Copy link
Member Author

vincepri commented Sep 4, 2019

We're currently working on a POC to use Prow to solve this issue. More information here: https://docs.google.com/document/d/1E2GOa3b9OgrI0PS2R-UVWDRi-m_Vd3va7cOkDQHDm5w/edit#

@ncdc
Copy link
Contributor

ncdc commented Sep 25, 2019

All done!
/close

@k8s-ci-robot
Copy link
Contributor

@ncdc: Closing this issue.

In response to this:

All done!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants