Fix registry-creds addon failure with ImageRepository

[alonyb]

This PR fixes #9722

It's not necessary make a reverse (#9725).

Problem was that addon was not loading data in this func to deployment file.
func (m *BinAsset) loadData(isTemplate bool) error
because isTemplate was always in false.

This PR only change a cred bool var to true in addon class (pkg/minikube/assets/addons.go)

In this PR #9551 this value should also have been changed.

Note: Since if you are going to use data load with jinja template as {{.ImageRepository}} in yaml file, you have to set the isTemplate variable into true, in case you are going to set it manually like "repository/nameImagev1.0", you can set isTemplate into false. All this is done in addons.go

Now it's working

[medyagh]

/ok-to-test

[medyagh]

would u plz put the out (failure) Before this PR in the description too?

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9733): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9733/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9733/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9733): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9733/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9733/minikube: exec format error

[alonyb]

would u plz put the out (failure) Before this PR in the description too?

Sure, it's done

[medyagh]

thank you for fixing this

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alonyb, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment