add ImageRepository to addons templates

[yehiyam]

fixes #8298

minikube start has a flag --image-repository that can be used to specify a private docker registry for pulling minikube images.
The imageRepository is used for some of the built in addons, but not for all of them.

For example, the ingress addon doesn't currently use the imageRepository

Before:

minikube start --image-repository some.docker.registry --addons ingress
kubectl get deploy -n kube-system ingress-nginx-controller -o jsonpath='{.spec.template.spec.containers[0].image}'

image is us.gcr.io/k8s-artifacts-prod/ingress-nginx/controller:v0.34.1@sha256...

After:

minikube start --image-repository some.docker.registry --addons ingress
kubectl get deploy -n kube-system ingress-nginx-controller -o jsonpath='{.spec.template.spec.containers[0].image}'

image is some.docker.registry/controller:v0.34.1

[k8s-ci-robot]

Welcome @yehiyam!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @yehiyam. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[codecov-io]

Codecov Report

Merging #9551 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9551   +/-   ##
=======================================
  Coverage   29.05%   29.05%           
=======================================
  Files         172      172           
  Lines       10482    10482           
=======================================
  Hits         3046     3046           
  Misses       7011     7011           
  Partials      425      425           

[medyagh]

do you mind putting in the PR description an example usage of this ? the Before and After this PR

otherwise the code looks good

[yehiyam]

@medyagh I've updated the PR description

[yehiyam]

@medyagh, @tstromberg did you have a chance to look over this PR?

[tstromberg]

Looks great. Thank you!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg, yehiyam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment