Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block on preload download #7003

Merged
merged 3 commits into from
Mar 11, 2020
Merged

block on preload download #7003

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb9cd3c
block on preload download
medyagh Mar 11, 2020
94dfb49
check for err
medyagh Mar 11, 2020
f92edc3
preload dont use gwait
medyagh Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/minikube/node/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ func beginCacheKubernetesImages(g *errgroup.Group, imageRepository string, k8sVe
glog.Info("Caching tarball of preloaded images")
return download.Preload(k8sVersion, cRuntime)
})
return
err := g.Wait()
medyagh marked this conversation as resolved.
Show resolved Hide resolved
if err == nil {
glog.Infof("Finished downloading the preloaded tar for %s on %s", k8sVersion, cRuntime)
return // don't cache individual images if preload is successful.
}
glog.Errorf("Error downloading preloaded artifacts will continue without preload: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this result in an error being displayed to the console on older ISO's?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this seems to be just downloading it, and it wont untar it yet or anything special

}

if !viper.GetBool("cache-images") {
Expand Down