Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block on preload download #7003

Merged
merged 3 commits into from
Mar 11, 2020
Merged

block on preload download #7003

merged 3 commits into from
Mar 11, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Mar 11, 2020 •
edited
Loading

before this PR:

"Creating Kubernetes in docker container"...starts while the preload is in progress
while this might be okay in VM world, because VM takes time to warm up but in docker it causes failures.

💾  Downloading preloaded images tarball for k8s v1.17.3 ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (2 available), Memory=4000MB (7964MB available) ...
    > preloaded-images-k8s-v1-v1.17.3-docker-overlay2.tar.lz4: 499.26 MiB / 499
...
...

❌  Unable to load cached images: loading cached images: stat /Users/medmac/.minikube/cache/images/gcr.io/k8s-minikube/storage-provisioner_v1.8.1: no such file or directory
    > kubelet.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
    > kubeadm.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
    > kubectl.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
...
...
...

After this PR: the docker driver will not fail if you purge:

medmac@~/workspace/minikube (preload_block) $ ./out/minikube delete --all --purge && ./out/minikube start --vm-driver=docker
🔥  Successfully deleted all profiles
💀  Successfully purged minikube directory located at - [/Users/medmac/.minikube]
😄  minikube v1.8.1 on Darwin 10.13.6
✨  Using the docker driver based on user configuration
💾  Downloading preloaded images tarball for k8s v1.17.3 ...
    > preloaded-images-k8s-v1-v1.17.3-docker-overlay2.tar.lz4: 499.26 MiB / 499
🔥  Creating Kubernetes in docker container with (CPUs=2) (2 available), Memory=4000MB (7964MB available) ...
🐳  Preparing Kubernetes v1.17.3 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🚀  Launching Kubernetes ... 
🌟  Enabling addons: default-storageclass, storage-provisioner
⌛  Waiting for cluster to come online ...
🏄  Done! kubectl is now configured to use "minikube"

Fixes #7000

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #7003 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7003   +/-   ##
=======================================
  Coverage   37.23%   37.23%           
=======================================
  Files         144      144           
  Lines        9079     9079           
=======================================
  Hits         3381     3381           
  Misses       5272     5272           
  Partials      426      426

@medyagh
Copy link
Member Author

medyagh commented Mar 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 11, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 67.138615 66.353262 66.192287]
All Times Minikube (PR 7003): [ 66.707328 67.876065 65.437503]

Average Minikube (PR 7003): 66.673632
Average minikube: 66.561388

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7003) |
+----------------------+-----------+--------------------+
| minikube v           |  0.226482 |           0.222233 |
| Creating kvm2        | 42.215997 |          41.307590 |
| Preparing Kubernetes |  0.792230 |           0.827212 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.318061 |          20.146566 |
| Waiting for cluster  |  0.063102 |           0.089824 |
+----------------------+-----------+--------------------+

tstromberg
tstromberg reviewed Mar 11, 2020
View reviewed changes
pkg/minikube/node/cache.go Outdated
glog.Infof("Finished downloading the preloaded tar for %s on %s", k8sVersion, cRuntime)
return // don't cache individual images if preload is successful.
}
glog.Errorf("Error downloading preloaded artifacts will continue without preload: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this result in an error being displayed to the console on older ISO's?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this seems to be just downloading it, and it wont untar it yet or anything special

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 66.099663 62.841955 64.575939]
All Times Minikube (PR 7003): [ 64.196036 65.826452 65.814252]

Average minikube: 64.505852
Average Minikube (PR 7003): 65.278913

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7003) |
+----------------------+-----------+--------------------+
| minikube v           |  0.214957 |           0.216579 |
| Creating kvm2        | 39.851354 |          38.975221 |
| Preparing Kubernetes |  0.786784 |           0.762980 |
| Pulling images       |           |                    |
| Launching Kubernetes | 21.071734 |          20.630630 |
| Waiting for cluster  |  0.057017 |           0.232094 |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit 8b99647 into kubernetes:master Mar 11, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 16, 2020
Merged
@medyagh medyagh deleted the preload_block branch May 2, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg left review comments

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preload: minikube continues before preload download is over
6 participants
@medyagh @k8s-ci-robot @codecov-io @minikube-pr-bot @tstromberg @priyawadhwa