Address some go9p issues adressed by SonarCloud #5550
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| return //NOSONAR | ||
|
|
||
| szerror: | ||
| return nil, &Error{"invalid size", EINVAL}, 0 |
There was a problem hiding this comment.
Instead of using NOSONAR, could you please refactor the code so that it returns the error inside the szerror label and remove the usage of Goto completely? I think that would be much better.
There was a problem hiding this comment.
The check is buggy, since the use of goto makes it entirely possible to have two exit points. i.e. it isn't dead code if someone is actually using it
Codecov Report
@@ Coverage Diff @@
## master #5550 +/- ##
=======================================
Coverage 36.63% 36.63%
=======================================
Files 102 102
Lines 7346 7346
=======================================
Hits 2691 2691
Misses 4298 4298
Partials 357 357 |
|
/retest this please |
|
/retest this please |
|
@minikube-bot OK to test |
|
This was for #5577 |
Some "major" issues shown in https://sonarcloud.io/project/issues?id=blueelvis_minikube&languages=go&resolved=false&types=BUG