Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get Sonarcloud setup for our main repository? #5577

Closed
blueelvis opened this issue Oct 9, 2019 · 5 comments
Closed

Can we get Sonarcloud setup for our main repository? #5577

blueelvis opened this issue Oct 9, 2019 · 5 comments
Labels
area/testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@blueelvis
Copy link
Contributor

Can we get Sonarcloud setup for our main repository? This is free for open source projects and provides valuable metrics like code quality issues and what not. It also supports Pull Request validations.

I have set it up on my fork and you can see the results over here - https://sonarcloud.io/dashboard?id=blueelvis_minikube

-Pranav

@medyagh
Copy link
Member

medyagh commented Oct 9, 2019

I don't see why not ! it is a good idea !

@medyagh medyagh added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/testing labels Oct 9, 2019
@tstromberg tstromberg added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/feature Categorizes issue or PR as related to a new feature. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 9, 2019
@afbjorklund
Copy link
Collaborator

Note that maintaining SonarQube is like a full-time position, due to the amount of false positives...

Still a good idea, but none of the current complaints seems like it was actually any real issue ?

i.e. it currently lists:

  • 12 Bugs
  • 234 Vulnerabilities
  • 276 Code Smells

All of these would need to be handled.


PS. I addressed the 3 Go bugs, the rest were in the website (8 HTML and 1 CSS)

And of the vulnerabilities, it is all about having "hardcoded IP addresses" in the tests.

@sharifelgamal
Copy link
Collaborator

Is this still something we're interested in supporting?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 15, 2020
@medyagh medyagh closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

7 participants