Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show info about the minikube linux distribution #4525

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Show info about the minikube linux distribution #4525

merged 3 commits into from
Jul 23, 2019

Commits on Jul 20, 2019

  1. Show information about the linux distribution 

    Taking from /etc/os-release, via libmachine provision

Failure to show it is not fatal, just log an error...
    @afbjorklund
    afbjorklund committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    60ff459 View commit details
    Browse the repository at this point in the history

  2. Use "OS release" instead of "distribution" 

    Makes it more clear that it is os-release(5)
    @afbjorklund
    afbjorklund committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    f11fc22 View commit details
    Browse the repository at this point in the history

  3. Return empty struct instead of nil pointer 

    Not very friendly to return nil without error
    @afbjorklund
    afbjorklund committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    d1cca95 View commit details
    Browse the repository at this point in the history