Show info about the minikube linux distribution #4525

afbjorklund · 2019-06-18T20:44:03Z

Taking from /etc/os-release, via libmachine provision

For #4523

k8s-ci-robot · 2019-06-18T20:44:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [afbjorklund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh · 2019-06-18T23:30:42Z

/retest this please

medyagh · 2019-06-19T01:58:30Z

there is a lint issue

cmd/minikube/cmd/start.go:546:53: unnecessary conversion (unconvert)
	osReleaseInfo, err := provision.NewOsRelease([]byte(osReleaseOut))
	                                                   ^
cmd/minikube/cmd/start.go:269:16: Error return value of `showOsRelease` is not checked (errcheck)
		showOsRelease()
		             ^

RA489 · 2019-06-19T10:30:54Z

/lint

k8s-ci-robot

@RA489: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

RA489 · 2019-06-19T10:32:18Z

@minikube-bot OK to test

tstromberg · 2019-06-21T00:18:47Z

I like this PR. I do agree that showing the distro is of most importance for the none drivers, but I would also like to show it for other platforms. We have the perfect space for it here:

😄 minikube v1.1.1 on linux (amd64)

What I propose is to place it here:

😄 minikube v1.1.1 on CentOS 4.5 (amd64)

In the future I would also like to extend this to Mac OS X & Windows as well, but surprisingly, I can't find any good libraries for doing so. That said, I'm perfectly OK with this approach as a stop-gap measure.

tstromberg · 2019-06-21T00:23:05Z

@minikube-bot OK to test

This can be merged once lint issues are addressed.

afbjorklund · 2019-06-21T07:58:02Z

I like this PR. I do agree that showing the distro is of most importance for the none drivers, but I would also like to show it for other platforms. We have the perfect space for it here:

😄 minikube v1.1.1 on linux (amd64)

What I propose is to place it here:

😄 minikube v1.1.1 on CentOS 4.5 (amd64)

They are talking about different things. One is showing information about the minikube binary (including the version and GOOS/GOARCH, which is defined to be one of "linux"/"windows/"darwin" and "amd64")

The other is showing information from the libmachine provisioner, i.e. what is being installed on the VM. Currently I used the same information also for the none driver, maybe that is what lead to the confusion.

afbjorklund · 2019-06-21T08:00:13Z

In the future I would also like to extend this to Mac OS X & Windows as well, but surprisingly, I can't find any good libraries for doing so. That said, I'm perfectly OK with this approach as a stop-gap measure.

Most other operating systems have this in their uname, since they don't have as many vendors as GNU/Linux does. So you would use the go equivalent of uname(2), with the "sysname" and "release"

medyagh

Looks good to me

medyagh · 2019-06-25T22:54:19Z

/retest this please

medyagh · 2019-07-01T21:46:02Z

/retest this please

tstromberg · 2019-07-11T18:14:08Z

@minikube-bot OK to test

tstromberg · 2019-07-11T18:16:57Z

Curious failure:

 16:30:48 | > * Creating none VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
 16:33:49 | ! E0701 16:33:49.321193   12847 start.go:633] StartHost: DetectProvisioner: Too many retries waiting for SSH to be available.  Last error: Maximum number of retries (60) exceeded
 16:33:49 | ! I0701 16:33:49.321250   12847 utils.go:129] non-retriable error: DetectProvisioner: Too many retries waiting for SSH to be available.  Last error: Maximum number of retries (60) exceeded
 16:33:49 | ! W0701 16:33:49.321383   12847 exit.go:100] Unable to start VM: DetectProvisioner: Too many retries waiting for SSH to be available.  Last error: Maximum number of retries (60) exceeded
 16:33:49 | ! X Unable to start VM: DetectProvisioner: Too many retries waiting for SSH to be available.  Last error: Maximum number of retries (60) exceeded
 16:33:49 | ! * Sorry that minikube crashed. If this was unexpected, we would love to hear from you:

Also, the Travis timeout makes me wonder if a unit test is starting up a real minikube rather than using mocks.

tstromberg · 2019-07-17T16:30:45Z

@minikube-bot OK to test

tstromberg · 2019-07-17T16:31:47Z

Looks like this one has a merge conflict now :(

afbjorklund · 2019-07-17T16:33:25Z

Ok, rebase time perhaps

afbjorklund · 2019-07-17T16:55:19Z

Moved into a proper function

tstromberg · 2019-07-17T18:12:18Z

go tests are still timing out in travis, so I wonder if additional mocking may be required?

ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.049s	coverage: 33.1% of statements
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

afbjorklund · 2019-07-18T07:23:11Z

go tests are still timing out in travis, so I wonder if additional mocking may be required?

Yes, there is something wrong with DetectProvisioner. Think we have seen this elsewhere too ?

Waiting for SSH to be available...

afbjorklund · 2019-07-18T07:38:17Z

Maybe should scope out the provisioned linux distribution for now. There's only one, anyway...

MockDriver needs the MockProvisioner

afbjorklund · 2019-07-18T10:33:41Z

Here is where it was seen before: #4132

⌛  Waiting for SSH access ...
Waiting for SSH to be available...
Getting to WaitForSSH function...
Error getting ssh command 'exit 0' : driver does not support ssh commands

afbjorklund · 2019-07-18T12:45:32Z

It seems that these tests have always been timing out, since they use VirtualBox and not Mock host...

Before: (6 minutes wasted!)
ok k8s.io/minikube/pkg/minikube/cluster 360.409s coverage: 50.6% of statements

After: (half a second now...)
ok k8s.io/minikube/pkg/minikube/cluster 0.467s coverage: 47.7% of statements

That is, we seem to be calling SSH a lot for drivers (none, unknown) that don't actually support it ?

afbjorklund · 2019-07-18T20:20:17Z

/retest was checking translations, and some weird sshutil error ?

tstromberg · 2019-07-20T00:03:20Z

/retest was checking translations, and some weird sshutil error ?

I think we've now addressed cluster_test, sshutil, and translation check issues. Sorry about the instability there!

pkg/minikube/cluster/cluster.go

Taking from /etc/os-release, via libmachine provision Failure to show it is not fatal, just log an error...

afbjorklund · 2019-07-20T08:16:49Z

Seems there is a bug in the MockDriver, where it returns nil information with nil error. Thanks.

Makes it more clear that it is os-release(5)

Not very friendly to return nil without error

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019

k8s-ci-robot requested review from medyagh and RA489 June 18, 2019 20:44

medyagh changed the title ~~Show information about the linux distribution~~ Show information about the linux distro for none driver Jun 18, 2019

medyagh changed the title ~~Show information about the linux distro for none driver~~ Show info about the linux distro for none driver Jun 18, 2019

k8s-ci-robot reviewed Jun 19, 2019

View reviewed changes

afbjorklund changed the title ~~Show info about the linux distro for none driver~~ Show info about the minikube linux distribution Jun 22, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2019

afbjorklund force-pushed the distro branch from a002f83 to 653cf07 Compare June 22, 2019 16:54

medyagh approved these changes Jun 25, 2019

View reviewed changes

afbjorklund force-pushed the distro branch 2 times, most recently from 793b8a4 to 44e50d4 Compare July 17, 2019 16:55

tstromberg added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2019

afbjorklund force-pushed the distro branch from 44e50d4 to 779e58d Compare July 18, 2019 06:58

afbjorklund removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2019

afbjorklund mentioned this pull request Jul 18, 2019

cluster_test is slow and is making unnecessary socket calls. #4810

Closed

afbjorklund force-pushed the distro branch from 428929d to 665b78f Compare July 19, 2019 07:04

tstromberg reviewed Jul 20, 2019

View reviewed changes

pkg/minikube/cluster/cluster.go Outdated Show resolved Hide resolved

Show information about the linux distribution

60ff459

Taking from /etc/os-release, via libmachine provision Failure to show it is not fatal, just log an error...

afbjorklund force-pushed the distro branch from 665b78f to 60ff459 Compare July 20, 2019 07:50

afbjorklund added 2 commits July 20, 2019 12:28

Use "OS release" instead of "distribution"

f11fc22

Makes it more clear that it is os-release(5)

Return empty struct instead of nil pointer

d1cca95

Not very friendly to return nil without error

afbjorklund requested a review from josedonizetti July 21, 2019 12:02

afbjorklund merged commit e22b605 into kubernetes:master Jul 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show info about the minikube linux distribution #4525

Show info about the minikube linux distribution #4525

afbjorklund commented Jun 18, 2019

k8s-ci-robot commented Jun 18, 2019

medyagh commented Jun 18, 2019

medyagh commented Jun 19, 2019

RA489 commented Jun 19, 2019

k8s-ci-robot left a comment

RA489 commented Jun 19, 2019

tstromberg commented Jun 21, 2019 •

edited

Loading

tstromberg commented Jun 21, 2019

afbjorklund commented Jun 21, 2019

afbjorklund commented Jun 21, 2019

medyagh left a comment

medyagh commented Jun 25, 2019

medyagh commented Jul 1, 2019

tstromberg commented Jul 11, 2019

tstromberg commented Jul 11, 2019

tstromberg commented Jul 17, 2019

tstromberg commented Jul 17, 2019

afbjorklund commented Jul 17, 2019

afbjorklund commented Jul 17, 2019

tstromberg commented Jul 17, 2019

afbjorklund commented Jul 18, 2019

afbjorklund commented Jul 18, 2019 •

edited

Loading

afbjorklund commented Jul 18, 2019

afbjorklund commented Jul 18, 2019 •

edited

Loading

afbjorklund commented Jul 18, 2019 •

edited

Loading

tstromberg commented Jul 20, 2019

afbjorklund commented Jul 20, 2019

Show info about the minikube linux distribution #4525

Show info about the minikube linux distribution #4525

Conversation

afbjorklund commented Jun 18, 2019

k8s-ci-robot commented Jun 18, 2019

medyagh commented Jun 18, 2019

medyagh commented Jun 19, 2019

RA489 commented Jun 19, 2019

k8s-ci-robot left a comment

Choose a reason for hiding this comment

RA489 commented Jun 19, 2019

tstromberg commented Jun 21, 2019 • edited Loading

tstromberg commented Jun 21, 2019

afbjorklund commented Jun 21, 2019

afbjorklund commented Jun 21, 2019

medyagh left a comment

Choose a reason for hiding this comment

medyagh commented Jun 25, 2019

medyagh commented Jul 1, 2019

tstromberg commented Jul 11, 2019

tstromberg commented Jul 11, 2019

tstromberg commented Jul 17, 2019

tstromberg commented Jul 17, 2019

afbjorklund commented Jul 17, 2019

afbjorklund commented Jul 17, 2019

tstromberg commented Jul 17, 2019

afbjorklund commented Jul 18, 2019

afbjorklund commented Jul 18, 2019 • edited Loading

afbjorklund commented Jul 18, 2019

afbjorklund commented Jul 18, 2019 • edited Loading

afbjorklund commented Jul 18, 2019 • edited Loading

tstromberg commented Jul 20, 2019

afbjorklund commented Jul 20, 2019

tstromberg commented Jun 21, 2019 •

edited

Loading

afbjorklund commented Jul 18, 2019 •

edited

Loading

afbjorklund commented Jul 18, 2019 •

edited

Loading

afbjorklund commented Jul 18, 2019 •

edited

Loading