Update cri-o from v1.20.0 to 1.22.0 #12425

spowelljr · 2021-09-07T22:54:33Z

deploy/iso/minikube-iso/package/crio-bin/crio-bin.mk

spowelljr · 2021-09-10T17:36:40Z

ok-to-build-image

minikube-bot · 2021-09-10T18:11:55Z

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

spowelljr · 2021-09-14T23:38:46Z

ok-to-build-iso

minikube-bot · 2021-09-15T00:37:09Z

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

spowelljr · 2021-09-15T01:09:06Z

/ok-to-test

minikube-pr-bot · 2021-09-15T02:14:37Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 48.5s    | 49.7s               |
| enable ingress | 34.1s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube start: 52.2s 47.9s 47.3s 47.3s 48.1s
Times for minikube (PR 12425) start: 51.8s 47.2s 51.6s 49.0s 48.9s

Times for minikube ingress: 41.3s 31.3s 32.3s 34.4s 31.3s
Times for minikube (PR 12425) ingress: 32.2s 33.4s 31.4s 30.8s 32.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 26.0s               |
| enable ingress | 29.8s    | 29.7s               |
+----------------+----------+---------------------+

Times for minikube start: 21.5s 21.1s 22.4s 21.2s 21.6s
Times for minikube (PR 12425) start: 45.4s 21.4s 21.2s 21.2s 20.6s

Times for minikube ingress: 26.9s 26.4s 36.4s 25.9s 33.4s
Times for minikube (PR 12425) ingress: 23.9s 34.4s 36.4s 26.0s 28.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 37.4s    | 43.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 26.2s 43.5s 29.7s 43.9s 43.8s
Times for minikube (PR 12425) start: 44.5s 44.3s 43.0s 43.1s 43.2s

minikube-pr-bot · 2021-09-15T04:28:01Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestNetworkPlugins/group/cilium/DNS (gopogh)	1.94 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	6.84 (chart)
KVM_Linux_containerd	TestAddons/parallel/HelmTiller (gopogh)	10.14 (chart)
Docker_Windows	TestInsufficientStorage (gopogh)	16.67 (chart)
Docker_Windows	TestScheduledStopWindows (gopogh)	22.92 (chart)
Docker_Windows	TestNetworkPlugins/group/auto/Start (gopogh)	28.91 (chart)
Docker_Linux	TestAddons/parallel/CSI (gopogh)	29.03 (chart)
KVM_Linux	TestAddons/parallel/CSI (gopogh)	32.67 (chart)
Docker_Windows	TestNetworkPlugins/group/false/Start (gopogh)	34.38 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	50.00 (chart)
Docker_Windows	TestFunctional/parallel/LoadImageFromFile (gopogh)	52.78 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	57.81 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	58.59 (chart)
Docker_Windows	TestPause/serial/VerifyStatus (gopogh)	59.03 (chart)
Docker_Windows	TestPause/serial/DeletePaused (gopogh)	59.44 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	60.94 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	64.84 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	79.69 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	91.41 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

Makefile

minikube-pr-bot · 2021-09-15T18:16:08Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 48.8s               |
| enable ingress | 32.6s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube start: 49.8s 50.3s 49.1s 48.3s 50.6s
Times for minikube (PR 12425) start: 51.9s 48.3s 48.6s 47.4s 47.7s

Times for minikube ingress: 31.4s 31.9s 34.8s 31.3s 33.3s
Times for minikube (PR 12425) ingress: 33.7s 32.4s 31.4s 31.8s 30.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 22.0s               |
| enable ingress | 31.7s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 12425) ingress: 26.4s 34.0s 26.4s 25.9s 26.0s
Times for minikube ingress: 27.9s 51.0s 25.9s 26.9s 26.9s

Times for minikube (PR 12425) start: 22.3s 22.4s 21.3s 21.4s 22.6s
Times for minikube start: 21.4s 21.5s 22.2s 21.7s 21.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 41.4s    | 36.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.3s 43.9s 43.4s 44.7s 43.6s
Times for minikube (PR 12425) start: 26.4s 43.1s 43.4s 25.6s 44.3s

minikube-pr-bot · 2021-09-15T19:23:59Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 47.4s               |
| enable ingress | 32.0s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 52.0s 46.4s 45.9s 46.6s 47.7s
Times for minikube (PR 12425) start: 47.4s 46.9s 48.6s 48.0s 46.1s

Times for minikube (PR 12425) ingress: 31.2s 31.8s 31.4s 31.3s 30.8s
Times for minikube ingress: 32.7s 31.3s 30.9s 32.7s 32.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.2s               |
| enable ingress | 30.0s    | 39.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 21.1s 21.7s 22.9s 21.0s
Times for minikube (PR 12425) start: 22.5s 21.0s 21.0s 20.1s 21.2s

Times for minikube ingress: 26.4s 27.4s 26.4s 34.4s 35.4s
Times for minikube (PR 12425) ingress: 26.4s 82.4s 34.9s 26.0s 26.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12425) |
+----------------+----------+---------------------+
| minikube start | 35.7s    | 38.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 29.3s 25.6s 43.8s 36.8s 43.0s
Times for minikube (PR 12425) start: 25.2s 43.2s 43.1s 42.9s 36.2s

minikube-pr-bot · 2021-09-15T21:15:50Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux	TestDebPackageInstall/install_amd64_ubuntu_20.04/kvm2-driver (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestAddons/parallel/Olm (gopogh)	3.90 (chart)
KVM_Linux	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	4.76 (chart)
Docker_Linux	TestFunctional/serial/ComponentHealth (gopogh)	4.97 (chart)
Docker_Windows	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	8.20 (chart)
KVM_Linux	TestAddons/parallel/Olm (gopogh)	9.62 (chart)
Docker_Windows	TestScheduledStopWindows (gopogh)	23.49 (chart)
KVM_Linux_containerd	TestAddons/parallel/CSI (gopogh)	24.68 (chart)
Docker_Windows	TestNetworkPlugins/group/auto/Start (gopogh)	28.79 (chart)
Docker_Linux_containerd	TestAddons/parallel/CSI (gopogh)	32.10 (chart)
Docker_Windows	TestNetworkPlugins/group/false/Start (gopogh)	34.85 (chart)
Docker_Windows	TestFunctional/parallel/DryRun (gopogh)	40.94 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	50.76 (chart)
Docker_Windows	TestFunctional/parallel/LoadImageFromFile (gopogh)	53.69 (chart)
Docker_Windows	TestFunctional/parallel/StatusCmd (gopogh)	55.03 (chart)
Docker_Windows	TestPause/serial/VerifyStatus (gopogh)	59.06 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	59.09 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	59.09 (chart)
Docker_Windows	TestPause/serial/DeletePaused (gopogh)	60.14 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	62.12 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	65.91 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	80.30 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	91.67 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)
Docker_Windows	TestCertOptions (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-09-15T23:04:36Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux	TestDebPackageInstall/install_amd64_ubuntu_20.04/kvm2-driver (gopogh)	0.00 (chart)
KVM_Linux	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	4.55 (chart)
Docker_Linux	TestPause/serial/PauseAgain (gopogh)	7.41 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/Pause (gopogh)	12.35 (chart)
Docker_Linux_containerd	TestDebPackageInstall/install_amd64_ubuntu_18.04/kvm2-driver (gopogh)	13.64 (chart)
Docker_Linux_containerd	TestPause/serial/Pause (gopogh)	18.40 (chart)
Docker_Linux_containerd	TestPause/serial/VerifyStatus (gopogh)	18.40 (chart)
Docker_Linux_containerd	TestPause/serial/PauseAgain (gopogh)	21.47 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	27.44 (chart)
KVM_Linux	TestAddons/parallel/CSI (gopogh)	32.48 (chart)
Docker_Linux_containerd	TestScheduledStopUnix (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2021-09-16T00:13:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2021

k8s-ci-robot requested review from medyagh and sharifelgamal September 7, 2021 22:55

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021

spowelljr commented Sep 7, 2021

View reviewed changes

deploy/iso/minikube-iso/package/crio-bin/crio-bin.mk Outdated Show resolved Hide resolved

spowelljr changed the title ~~Update cri-o from v1.20.0 to 1.22.0~~ WIP: Update cri-o from v1.20.0 to 1.22.0 Sep 8, 2021

spowelljr force-pushed the updateCrio branch from acf60dc to 065ed7a Compare September 10, 2021 17:35

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2021

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2021

spowelljr and others added 10 commits September 14, 2021 09:50

update cri-o from v1.20.0 to 1.22.0

c31db4f

remove var

623c01c

skip cri-o installation on unsupported archs

1bc8411

prevent user from using crio on unsupported hardware

8304e52

only disable crio if installed

5243af5

crio enabled s390x arch

debae03

Updating kicbase image to v0.0.26-1631295795-12425

030b383

undo validation changes

7dfb817

run make generate-docs

5c2c765

make sure current go version is installed

16941e8

spowelljr force-pushed the updateCrio branch from d7226cd to 16941e8 Compare September 14, 2021 16:51

kubernetes deleted a comment from minikube-bot Sep 14, 2021

updated hash list

0e02c5f

kubernetes deleted a comment from minikube-bot Sep 14, 2021

remove v from go version

9155921

kubernetes deleted a comment from minikube-bot Sep 14, 2021

Updating ISO to v1.23.0-1631662909-12425

d52130b

kubernetes deleted a comment from minikube-bot Sep 15, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 15, 2021

remove commented out code

b9d7ac9

spowelljr changed the title ~~WIP: Update cri-o from v1.20.0 to 1.22.0~~ Update cri-o from v1.20.0 to 1.22.0 Sep 15, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2021

medyagh reviewed Sep 15, 2021

View reviewed changes

Makefile Show resolved Hide resolved

add comment about go version

07c6aa0

sharifelgamal approved these changes Sep 16, 2021

View reviewed changes

spowelljr mentioned this pull request Sep 16, 2021

buildkit socket: Add systemd unit #12081

Merged

spowelljr merged commit 1936a7b into kubernetes:master Sep 16, 2021

spowelljr deleted the updateCrio branch September 16, 2021 01:21

spowelljr mentioned this pull request Sep 22, 2021

crio.conf empty with Docker driver #12552

Closed

klaases mentioned this pull request Nov 15, 2021

update cri-o from v1.22.0 to 1.22.1 #12959

Closed

klaases mentioned this pull request Dec 1, 2021

update cri-o from v1.22.0 to 1.22.1 #13059

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update cri-o from v1.20.0 to 1.22.0 #12425

Update cri-o from v1.20.0 to 1.22.0 #12425

spowelljr commented Sep 7, 2021

spowelljr commented Sep 10, 2021

minikube-bot commented Sep 10, 2021

spowelljr commented Sep 14, 2021

minikube-bot commented Sep 15, 2021

spowelljr commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

k8s-ci-robot commented Sep 16, 2021

Update cri-o from v1.20.0 to 1.22.0 #12425

Update cri-o from v1.20.0 to 1.22.0 #12425

Conversation

spowelljr commented Sep 7, 2021

spowelljr commented Sep 10, 2021

minikube-bot commented Sep 10, 2021

spowelljr commented Sep 14, 2021

minikube-bot commented Sep 15, 2021

spowelljr commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

minikube-pr-bot commented Sep 15, 2021

k8s-ci-robot commented Sep 16, 2021