Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crio.conf empty with Docker driver #12552

Closed
spowelljr opened this issue Sep 22, 2021 · 6 comments · Fixed by #13531
Closed

crio.conf empty with Docker driver #12552

spowelljr opened this issue Sep 22, 2021 · 6 comments · Fixed by #13531
Assignees
@spowelljr
Labels
co/docker-driver Issues related to kubernetes in container co/kic-base co/runtime/crio CRIO related issues help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
1.26.0

Comments

@spowelljr
Copy link
Member

Since updating cri-o from 1.20 to 1.22 (#12425) the /etc/crio/crio.conf file is empty when using the Docker driver.
@spowelljr spowelljr added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. co/runtime/crio CRIO related issues co/docker-driver Issues related to kubernetes in container labels Sep 22, 2021
@spowelljr spowelljr added this to the 1.24.0 milestone Sep 22, 2021
@spowelljr spowelljr self-assigned this Sep 22, 2021
@afbjorklund
Copy link
Collaborator

afbjorklund commented Sep 23, 2021 •
edited
Loading

Maybe bug in the OBS package ?

@afbjorklund
Copy link
Collaborator

It was a change in cri-o, not listing default configuration...

It is being reverted for 1.22, but maybe a good idea to move to /etc/crio.conf.d anyway ?

@spowelljr
Copy link
Member Author

@afbjorklund Will the crio.conf file being empty affect us in anyway?

@spowelljr spowelljr removed their assignment Sep 23, 2021
@afbjorklund
Copy link
Collaborator

I think we try to change things (using sed), so that fails...

@spowelljr spowelljr added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 3, 2021
@spowelljr spowelljr modified the milestones: 1.24.0, 1.25.0-candidate Nov 5, 2021
@spowelljr
Copy link
Member Author

See how soon crio is going to revert this and then decide from there

@spowelljr spowelljr added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 8, 2021
@medyagh
Copy link
Member

medyagh commented Jan 31, 2022

The recommendation to have a generic config template and if the installed crio doesn not have config, we should geneate one

@spowelljr spowelljr self-assigned this Jan 31, 2022
@spowelljr spowelljr mentioned this issue Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spowelljr spowelljr

Labels
co/docker-driver Issues related to kubernetes in container co/kic-base co/runtime/crio CRIO related issues help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
1.26.0
Development

Successfully merging a pull request may close this issue.

crio: use drop in configuration files spowelljr/minikube
4 participants
@medyagh @afbjorklund @sharifelgamal @spowelljr