Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Jaeger and Opentracing in favor of OpenTelemetry #8687

Closed
rikatz opened this issue Jun 12, 2022 · 16 comments
Closed

Deprecate Jaeger and Opentracing in favor of OpenTelemetry #8687

rikatz opened this issue Jun 12, 2022 · 16 comments
Assignees
Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rikatz
Copy link
Contributor

rikatz commented Jun 12, 2022

OTEL is around for a while. We even have a starting implementation in NGINX.

In an effort to simplify our code, the compilation times, etc we need to remove the features Jaeger and Opentracing and keep only opentelemetry.

To not break users, maybe we need to analyze when an old jaeger directive was used and configure otel to send proper traces. We need to check;

  • Is OTEL compatible with Jaeger? Can we just migrate the configs of Jaeger to OTEL (in NGINX tempalte?)
  • Is OTEL compatible with OpenTracing? Same as above?

This is just a boilerplate issue, but we need to evolve it

/triage accepted
/kind cleanup
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 12, 2022
@rikatz
Copy link
Contributor Author

rikatz commented Jun 12, 2022

https://www.jaegertracing.io/docs/1.35/client-libraries/ <- Reference on the Jaeger clients being deprecated

@tao12345666333
Copy link
Member

Probably we also need to know how many people are currently using this feature.

@rikatz
Copy link
Contributor Author

rikatz commented Jun 15, 2022

Jaeger cli is deprecated so we can move this.

@strongjz strongjz added the area/stabilization Work for increasing stabilization of the ingress-nginx codebase label Jun 23, 2022
@andremarianiello
Copy link
Contributor

andremarianiello commented Aug 31, 2022

jaeger-client-cpp is no longer fixing bugs jaegertracing/jaeger-client-cpp#292, so OpenTelemetry support has become more important

@andremarianiello
Copy link
Contributor

What is blocking this, exactly?

@longwuyuan
Copy link
Contributor

No blocker per se, but there is stabilization work in progress so lack of developer time. As soon as the higher priority stabiilization work is under control, some developer time will go into opentelemetry.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@andremarianiello
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2022
@esigo
Copy link
Member

esigo commented Nov 29, 2022

/assign

@rikatz
Copy link
Contributor Author

rikatz commented Jun 29, 2023

We should keep an eye also on #10082

@tao12345666333
Copy link
Member

I think for #10082 we have reached an agreement. #10082 (comment)

And I saw there has a PR #10151 works and relegated with this one.

@longwuyuan
Copy link
Contributor

/assign

@longwuyuan
Copy link
Contributor

We have to support opentracing for controller v1.9 builds so this PR #10913 needs to be cleaned up and merged after releasing controller v1.11

@longwuyuan
Copy link
Contributor

Controller v1.11 released so closing this issue

/close

@k8s-ci-robot
Copy link
Contributor

@longwuyuan: Closing this issue.

In response to this:

Controller v1.11 released so closing this issue

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

8 participants