-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add soltysh to prod-readiness-approvers #4566
Conversation
/assign @deads2k @johnbelamaric @wojtek-t |
/assign @jpbetz |
Thanks @soltysh! I appreciate all your work on PRR thus far! I spot checked the reviews and they appear to meet our criteria. I'll defer to the tenured PRR reviewers for decision making on this one. |
I'm supportive. @deads2k @johnbelamaric - we probably need one more vote from one of you :) |
me too. /lgtm holding for @johnbelamaric |
/lgtm woo hoo! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Shadow contribution summary:
Planned future involvement:
Shadow reviewer promotion criteria:
Transitions from new to alpha
Transitions from alpha to beta
Transitions from beta to GA
Must have successfully reviewed at least three enhancements that require coordination between multiple components.
Must have successfully reviewed at least three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.
Must have successfully reviewed at least three enhancements that are outside your primary domain.
Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.
Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.