Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soltysh to prod-readiness-approvers #4566

Merged
merged 1 commit into from
May 11, 2024

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Apr 3, 2024

Shadow contribution summary:

  • 1.29 shadow reviews: 9
  • 1.30 shadow reviews: 8

Planned future involvement:

  • 1.31+ I'm planning to continue my contributions to PRR, hopefully reaching 10 KEPs/release cycle, aside from the ones I'm looking at as sig apps and sig cli lead.

Shadow reviewer promotion criteria:

Transitions from new to alpha

Transitions from alpha to beta

Transitions from beta to GA

Must have successfully reviewed at least three enhancements that require coordination between multiple components.

Must have successfully reviewed at least three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.

Must have successfully reviewed at least three enhancements that are outside your primary domain.

Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.

Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2024
@soltysh
Copy link
Contributor Author

soltysh commented Apr 3, 2024

/assign @deads2k @johnbelamaric @wojtek-t

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2024
@soltysh
Copy link
Contributor Author

soltysh commented Apr 3, 2024

/assign @jpbetz

@jpbetz
Copy link
Contributor

jpbetz commented Apr 12, 2024

Thanks @soltysh! I appreciate all your work on PRR thus far!

I spot checked the reviews and they appear to meet our criteria. I'll defer to the tenured PRR reviewers for decision making on this one.

@wojtek-t
Copy link
Member

I'm supportive.

@deads2k @johnbelamaric - we probably need one more vote from one of you :)

@deads2k
Copy link
Contributor

deads2k commented May 6, 2024

I'm supportive.

@deads2k @johnbelamaric - we probably need one more vote from one of you :)

me too.

/lgtm
/hold

holding for @johnbelamaric

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 6, 2024
@johnbelamaric
Copy link
Member

/lgtm
/hold cancel

woo hoo!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2024
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 219fba2 into kubernetes:master May 11, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 11, 2024
@soltysh soltysh deleted the prr-approvers branch May 13, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants