Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3352: Aggregated Discovery to GA #4472

Merged
merged 1 commit into from
Feb 8, 2024
Merged

KEP-3352: Aggregated Discovery to GA #4472

merged 1 commit into from
Feb 8, 2024

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Feb 1, 2024

  • One-line PR description: KEP-3352: Aggregated Discovery to GA
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2024
@Jefftree
Copy link
Member Author

Jefftree commented Feb 1, 2024

/assign @deads2k @jpbetz

@jpbetz jpbetz mentioned this pull request Feb 2, 2024
Closed
11 tasks
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2024
soltysh
soltysh reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#prr-shadow
Several nits from the PRR review pov.

keps/sig-api-machinery/3352-aggregated-discovery/README.md Show resolved Hide resolved
keps/sig-api-machinery/3352-aggregated-discovery/README.md Show resolved Hide resolved
keps/sig-api-machinery/3352-aggregated-discovery/README.md Show resolved Hide resolved
@jpbetz
Copy link
Contributor

jpbetz commented Feb 7, 2024

PRR LGTM once my name is swapped in to the prr yaml file

soltysh
soltysh reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#prr-shadow
a more nits 😅

keps/sig-api-machinery/3352-aggregated-discovery/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/3352-aggregated-discovery/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/3352-aggregated-discovery/README.md Show resolved Hide resolved
@jpbetz
Copy link
Contributor

jpbetz commented Feb 7, 2024

/approve PRR

Any concerns from a SIG leads perspective @deads2k?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Feb 8, 2024

/lgtm
I think this one is ready.

Thanks @Jefftree

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2ed09de into kubernetes:master Feb 8, 2024
3 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 8, 2024
@soltysh soltysh mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@soltysh soltysh soltysh left review comments

@jpbetz jpbetz jpbetz left review comments

@apelisse apelisse Awaiting requested review from apelisse

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@jpbetz jpbetz

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
6 participants
@Jefftree @jpbetz @k8s-ci-robot @soltysh @sftim @deads2k