Chore: fixed lints errors

[omerap12]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR addresses several linting issues identified in the codebase, as follows:

 ~/Desktop/PersonlRepos/autoscaler/vertical-pod-autoscaler/ [master] golangci-lint run          
pkg/updater/eviction/pods_eviction_restriction_test.go:645:18: Error return value of `eviction.Evict` is not checked (errcheck)
                        eviction.Evict(p.pod, testCase.vpa, mockRecorder)
                                      ^
pkg/updater/priority/update_priority_calculator.go:196:56: SA1019: sets.String is deprecated: use generic Set instead. new ways: s1 := Set[string]{} s2 := New[string]() (staticcheck)
func parseVpaObservedContainers(pod *apiv1.Pod) (bool, sets.String) {
                                                       ^
pkg/utils/status/status_object.go:177:10: SA1019: netError.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method. (staticcheck)
                return netError.Temporary() || netError.Timeout()
                       ^
pkg/utils/status/status_object.go:31:2: SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
        "k8s.io/utils/pointer"
        ^

This PR fixes those issues.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Should we add golangci-lint run to our GitHub Actions pipeline? It seems like a helpful way to catch these issues early.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[omerap12]

@adrianmoisey error check here caused a failure (https://github.com/kubernetes/autoscaler/actions/runs/12082981510/job/33695187736) so I ignore that for now.

[adrianmoisey]

Oh interesting. Based on this test, I think that error is expected, since the pod can't be evicted.
Would you be able to change the test to include testing if an error is expected or not?

[omerap12]

sure. In this PR?

[adrianmoisey]

I'm not too fussed, your choice

[omerap12]

👍

[adrianmoisey]

/lgtm

[voelzmo]

Thanks for the PR!

Should we add golangci-lint run to our GitHub Actions pipeline? It seems like a helpful way to catch these issues early.

Yeah, absolutely! I think this is the only way to keep these errors out of the codebase.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerap12, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS [voelzmo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[omerap12]

Thanks for the PR!

Should we add golangci-lint run to our GitHub Actions pipeline? It seems like a helpful way to catch these issues early.

Yeah, absolutely! I think this is the only way to keep these errors out of the codebase.

/approve

Ill raise a PR then :)

[ialidzhikov]

Why you introduce a new no-op empty line?

[omerap12]

by mistake, Ill raise a PR to fix thanks