Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA: add if error is expected in pods_eviction_restriction_test #7544

Closed
omerap12 opened this issue Nov 29, 2024 · 3 comments · Fixed by #7555
Closed

VPA: add if error is expected in pods_eviction_restriction_test #7544

omerap12 opened this issue Nov 29, 2024 · 3 comments · Fixed by #7555
Assignees
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@omerap12
Copy link
Member

omerap12 commented Nov 29, 2024

Which component are you using?:
VPA

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
Currently we have unit tests in: here we need to include if an error is expected or not in each unit case ( otherwise we can just ignore some errors if they are expected but then we get a lint error (ref: #7542 (comment))
Opening this issue to track and address the problem so it isn’t overlooked.

Describe the solution you'd like.:
Each test should say if we expect an error or not.

Describe any alternative solutions you've considered.:

Additional context.:

@omerap12 omerap12 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2024
@adrianmoisey
Copy link
Member

/area vertical-pod-autoscaler

@adrianmoisey
Copy link
Member

/retitle VPA: add if error is expected in pods_eviction_restriction_test

@k8s-ci-robot k8s-ci-robot changed the title VPA: add if error is expected in pods_eviction_restrictio_test VPA: add if error is expected in pods_eviction_restriction_test Dec 3, 2024
@omerap12
Copy link
Member Author

omerap12 commented Dec 3, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants