Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_instance_types CA cherry picks to 1.2 #1478

Merged
merged 2 commits into from
Dec 6, 2018
Merged

ec2_instance_types CA cherry picks to 1.2 #1478

merged 2 commits into from
Dec 6, 2018

Conversation

typical-whack
Copy link
Contributor

No description provided.

Update AWS EC2 instance type catalog
edc7252 
Run "make generate" to pull and translate a fresh catalog of AWS's
available EC2 instance types used by the cluster autoscaler.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2018
@losipiuk
Copy link
Contributor

losipiuk commented Dec 5, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2018
@losipiuk
Copy link
Contributor

losipiuk commented Dec 5, 2018

There is Travis failure. Can you look at it?

@typical-whack
Copy link
Contributor Author

typical-whack commented Dec 5, 2018 •
edited
Loading

looks to be related to:
#516 / #608
looks like this test is disabled on master:

autoscaler/cluster-autoscaler/cloudprovider/aws/aws_manager_test.go

Line 306 in 991873c

/* Disabled due to flakiness. See https://github.com/kubernetes/autoscaler/issues/608

I can cherry-pick the commit to disable that test into this branch if you'd like:
e93e25d

@losipiuk
Copy link
Contributor

losipiuk commented Dec 5, 2018

/retest

@losipiuk
Copy link
Contributor

losipiuk commented Dec 5, 2018

I guess /retest does not work here.

@jeruane Thanks for checking.
It would be great if you added cherry-picking the e93e25d as part of this PR.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2018
@losipiuk
Copy link
Contributor

losipiuk commented Dec 6, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dc71b12 into kubernetes:cluster-autoscaler-release-1.2 Dec 6, 2018
@typical-whack typical-whack deleted the jruane-patch-4 branch December 6, 2018 20:14
@Jeffwan Jeffwan mentioned this pull request Dec 6, 2018
Closed
@ghost ghost mentioned this pull request Dec 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees

@losipiuk losipiuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@typical-whack @losipiuk @k8s-ci-robot @aleksandra-malinowska