Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Autoscaler 1.2.4 #1337

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Cluster Autoscaler 1.2.4 #1337

merged 1 commit into from
Jan 7, 2019

Conversation

aleksandra-malinowska
Copy link
Contributor

Update Cluster Autoscaler version to 1.2.4

@aleksandra-malinowska aleksandra-malinowska added this to the CA-1.2 milestone Oct 22, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2018
@aleksandra-malinowska aleksandra-malinowska mentioned this pull request Oct 23, 2018
Merged
@MaciekPytel
Copy link
Contributor

/lgtm
/approve
/hold
I think fixing test is just a matter of rebasing? Either way it should pass before merging.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2018
@aleksandra-malinowska
Copy link
Contributor Author

It isn't, see #1346

@feiskyer
Copy link
Member

Since this is still not ready yet, could we wait a while for a critical bug fix for Azure?

@Jeffwan
Copy link
Contributor

Jeffwan commented Dec 7, 2018

#1485 will fix flaking UT and this should be unblocked

@MaciekPytel
Copy link
Contributor

Note that Kubernetes 1.10 (and by extension CA 1.2) will go end of life in the next few days. Ideally CA 1.2.4 should be released in time to make it into the final 1.10 release. So we don't have much time for fixes.

@ghost
Copy link

ghost commented Dec 19, 2018

Can we move forward here to release with #1478 please ?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2019
@losipiuk
Copy link
Contributor

losipiuk commented Jan 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aleksandra-malinowska aleksandra-malinowska removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit e258d5e into kubernetes:cluster-autoscaler-release-1.2 Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk Awaiting requested review from losipiuk

@feiskyer feiskyer Awaiting requested review from feiskyer

@piosz piosz Awaiting requested review from piosz

Assignees

@losipiuk losipiuk

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cherrypick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
CA-1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@aleksandra-malinowska @MaciekPytel @feiskyer @Jeffwan @losipiuk @k8s-ci-robot