Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor adding logging flags #546

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Refactor adding logging flags #546

merged 1 commit into from
Dec 9, 2022

Conversation

olivierlemasle
Copy link
Member

Instead of using logs.AddGoFlags(local) to add logging flags to Go flags.FlagSet, then adding them to github.com/spf13/pflag.FlagSet, we directly add them to github.com/spf13/pflag.FlagSet.

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 5, 2022
@k8s-ci-robot
Copy link
Contributor

@olivierlemasle: This issue is currently awaiting triage.

If prometheus-adapter contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2022
dgrisonnet
dgrisonnet reviewed Dec 9, 2022
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, olivierlemasle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit e18cc18 into kubernetes-sigs:master Dec 9, 2022
@olivierlemasle olivierlemasle deleted the log-flags branch December 9, 2022 15:16
@dgrisonnet dgrisonnet mentioned this pull request Jul 25, 2023
Closed
monitoring-commit-bot bot pushed a commit to rhobs/k8s-prometheus-adapter that referenced this pull request Aug 10, 2023
@github-actions
Merge tag 'refs/tags/v0.11.0'
87aacbe 
Changes since v0.10.0

Logging flags that are klog specific (`--log-dir`, `--log-file`, `--logtostderr`, `--alsologtostderr`, `--one-output`, `--stderrthreshold`, `--log-file-max-size`, `--skip-log-headers`, `--add-dir-header`, `--skip-headers`, `--log-backtrace-at`) were deprecated in v0.10.0 and are now **removed**.

Improvements

* Bump go to 1.20 and k8s deps to 0.27.2 (kubernetes-sigs#586, @dgrisonnet)
* Add support for OpenAPI v3 (kubernetes-sigs#586, @dgrisonnet)
* Update registry location to registry.k8s.io in the manifests (kubernetes-sigs#529, @dgrisonnet)
* Update manifests in deploy/manifests to be in sync with the one in kube-prometheus (kubernetes-sigs#531, @JoaoBraveCoding)
* Use golangci-lint to lint the codebase (kubernetes-sigs#540, @olivierlemasle)
* Set MinVersion: tls.VersionTLS12 in prometheus client's TLSClientConfig (kubernetes-sigs#544, @olivierlemasle)
* Refactor adding logging flags (kubernetes-sigs#546, @olivierlemasle)

Bug fixes

* Fix segfault when using --prometheus-token-file (kubernetes-sigs#538, @olivierlemasle)

Documentation

* Fix broken links in README.md (kubernetes-sigs#518, @sillyfrog)
* Fix yaml in sample config & docs (kubernetes-sigs#559, @asherf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivierlemasle @k8s-ci-robot @dgrisonnet