Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links in README.md #518

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix broken links in README.md #518

merged 1 commit into from
Dec 13, 2022

Conversation

sillyfrog
Copy link
Contributor

Minor issue, fixes a few broken links to the (now finalized) Metrics APIs.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 20, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 20, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @sillyfrog!

It looks like this is your first PR to kubernetes-sigs/prometheus-adapter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prometheus-adapter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @sillyfrog. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 20, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2022
@sillyfrog
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2022
olivierlemasle
olivierlemasle approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@olivierlemasle olivierlemasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 5, 2022
@dgrisonnet
Copy link
Member

Sorry I missed this PR.

Thank you for sending the fix @sillyfrog, would you mind squashing the commits into one?

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2022
@sillyfrog sillyfrog closed this Dec 10, 2022
@k8s-ci-robot k8s-ci-robot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 10, 2022
@sillyfrog sillyfrog reopened this Dec 10, 2022
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 10, 2022
@sillyfrog
Copy link
Contributor Author

@dgrisonnet That's done, made a bit of a mess of it, but I've just re-applied the patch on the current master. Please let me know if there's anything else you need.

Cheers.

olivierlemasle
olivierlemasle approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@olivierlemasle olivierlemasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sillyfrog
/triage accepted
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2022
@dgrisonnet
Copy link
Member

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, olivierlemasle, sillyfrog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit b233597 into kubernetes-sigs:master Dec 13, 2022
@dgrisonnet dgrisonnet mentioned this pull request Jul 25, 2023
Closed
monitoring-commit-bot bot pushed a commit to rhobs/k8s-prometheus-adapter that referenced this pull request Aug 10, 2023
@github-actions
Merge tag 'refs/tags/v0.11.0'
87aacbe 
Changes since v0.10.0

Logging flags that are klog specific (`--log-dir`, `--log-file`, `--logtostderr`, `--alsologtostderr`, `--one-output`, `--stderrthreshold`, `--log-file-max-size`, `--skip-log-headers`, `--add-dir-header`, `--skip-headers`, `--log-backtrace-at`) were deprecated in v0.10.0 and are now **removed**.

Improvements

* Bump go to 1.20 and k8s deps to 0.27.2 (kubernetes-sigs#586, @dgrisonnet)
* Add support for OpenAPI v3 (kubernetes-sigs#586, @dgrisonnet)
* Update registry location to registry.k8s.io in the manifests (kubernetes-sigs#529, @dgrisonnet)
* Update manifests in deploy/manifests to be in sync with the one in kube-prometheus (kubernetes-sigs#531, @JoaoBraveCoding)
* Use golangci-lint to lint the codebase (kubernetes-sigs#540, @olivierlemasle)
* Set MinVersion: tls.VersionTLS12 in prometheus client's TLSClientConfig (kubernetes-sigs#544, @olivierlemasle)
* Refactor adding logging flags (kubernetes-sigs#546, @olivierlemasle)

Bug fixes

* Fix segfault when using --prometheus-token-file (kubernetes-sigs#538, @olivierlemasle)

Documentation

* Fix broken links in README.md (kubernetes-sigs#518, @sillyfrog)
* Fix yaml in sample config & docs (kubernetes-sigs#559, @asherf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierlemasle olivierlemasle olivierlemasle approved these changes

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@olivierlemasle olivierlemasle

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sillyfrog @k8s-ci-robot @k8s-triage-robot @dgrisonnet @olivierlemasle