Fix openapi #335
Merged
Fix openapi #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneswuerbach
force-pushed
the
fix-openapi
branch
2 times, most recently
from
be3dbb5 to
8da4c69
Compare
|
leaving the final review to @dgrisonnet :-) |
dgrisonnet
reviewed
Nov 10, 2020
There was a problem hiding this comment.
I just have a few nit comments. Thank you for taking the time to look into this issue @johanneswuerbach.
johanneswuerbach
force-pushed
the
fix-openapi
branch
from
8da4c69 to
4d0d0f3
Compare
|
lgtm once green, thank you everybody for tackling this one! Once merged, I will release 0.8.2 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
Update custom-metrics-apiserver to include kubernetes-sigs/custom-metrics-apiserver#75 and update openapi generation task to keep schema in sync with k8s version.