Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openapi rendering issue and build tooling improvements #75

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

johanneswuerbach
Copy link
Contributor

Resolves "Failed to build open api spec for root: non-body Restful parameter type should be a simple type, but got : v1.ResourceVersionMatch"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 9, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 9, 2020
@johanneswuerbach
Copy link
Contributor Author

/assign @s-urbaniak

@s-urbaniak
Copy link
Contributor

@johanneswuerbach wonderful, thank you! reviewing and also cc'ing @dgrisonnet

@s-urbaniak
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2020
@s-urbaniak
Copy link
Contributor

lgtm, again, thank you so much @johanneswuerbach ! 🚀

@s-urbaniak
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johanneswuerbach, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2e93ea9 into kubernetes-sigs:master Nov 9, 2020
@s-urbaniak
Copy link
Contributor

@johanneswuerbach do you want to tackle the bump in prometheus-adapter as well? Once done, I can release a 0.8.2 immediately.

@johanneswuerbach
Copy link
Contributor Author

Yes, working on it now :-)

@johanneswuerbach johanneswuerbach deleted the fix-openapi branch November 9, 2020 13:34
@s-urbaniak
Copy link
Contributor

@johanneswuerbach fyi: @dgrisonnet found out something is broken with the build though.

@johanneswuerbach
Copy link
Contributor Author

Let me know if you need any help, here is the k8s-prometheus-adapter PR kubernetes-sigs/prometheus-adapter#335

@dgrisonnet
Copy link
Member

The fix seems to be working properly as far as I tested with the test-adapter so I think we can move on with the prometheus-adapter bump.
However, when I was trying to build this project in a freshly cloned repo, the openapi files were not getting generated, which resulted in build errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants