-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix openapi rendering issue and build tooling improvements #75
Fix openapi rendering issue and build tooling improvements #75
Conversation
/assign @s-urbaniak |
@johanneswuerbach wonderful, thank you! reviewing and also cc'ing @dgrisonnet |
/lgtm |
lgtm, again, thank you so much @johanneswuerbach ! 🚀 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johanneswuerbach, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@johanneswuerbach do you want to tackle the bump in prometheus-adapter as well? Once done, I can release a 0.8.2 immediately. |
Yes, working on it now :-) |
@johanneswuerbach fyi: @dgrisonnet found out something is broken with the build though. |
Let me know if you need any help, here is the k8s-prometheus-adapter PR kubernetes-sigs/prometheus-adapter#335 |
The fix seems to be working properly as far as I tested with the test-adapter so I think we can move on with the prometheus-adapter bump. |
Resolves "Failed to build open api spec for root: non-body Restful parameter type should be a simple type, but got : v1.ResourceVersionMatch"