Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete WNode implementation #2893

Closed
monopole opened this issue Aug 26, 2020 · 2 comments
Closed

Complete WNode implementation #2893

monopole opened this issue Aug 26, 2020 · 2 comments
Labels
area/api issues for api module area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v3.8.8

Comments

@monopole
Copy link
Contributor

monopole commented Aug 26, 2020 •
edited
Loading

In service of #2506, which will permit completion of #1500

The methods to implement are here:
https://github.com/kubernetes-sigs/kustomize/tree/master/api/internal/wrappy/wnode.go

For details / rationale, see
https://github.com/kubernetes-sigs/kustomize/blob/master/api/krusty/internal/provider/depprovider.go

The other half of this is #2894

It's desirable to try to reduce the WNode interface to reduce the implementation work. Please file new issues if we can identify deprecations that reduce the number of methods in the WNode interface.
@monopole monopole added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 26, 2020
@monopole monopole mentioned this issue Aug 26, 2020
Closed
@monopole monopole added the area/dependency Issues or PRs related to dependency changes label Oct 14, 2020
@brianpursley brianpursley mentioned this issue Oct 19, 2020
Merged
@Shell32-Natsu Shell32-Natsu added area/api issues for api module kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 21, 2020
monopole added a commit to monopole/kustomize that referenced this issue Nov 25, 2020
@monopole
Add label and annotation selector code.
dbd7616 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 25, 2020
@monopole
Add label and annotation selector code.
d2a2dd1 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 25, 2020
@monopole
Add label and annotation selector code.
e6b02e2 
Closes kubernetes-sigs#2893
@monopole monopole mentioned this issue Nov 25, 2020
Merged
@Shell32-Natsu Shell32-Natsu added this to the v3.8.8 milestone Nov 25, 2020
monopole added a commit to monopole/kustomize that referenced this issue Nov 25, 2020
@monopole
Add label and annotation selector code.
5af4a81 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 25, 2020
@monopole
Add label and annotation selector code.
c3f9e1b 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
47e6b07 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
5335b3c 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
47d362b 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
88e50a5 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
a3dbb2c 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
6daae86 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
d649143 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
caac3f7 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
d7969b8 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
2014bbb 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
12de0b2 
Closes kubernetes-sigs#2893
monopole added a commit to monopole/kustomize that referenced this issue Nov 26, 2020
@monopole
Add label and annotation selector code.
440da7c 
Closes kubernetes-sigs#2893
@Shell32-Natsu
Copy link
Contributor

@monopole I think this has been finished?

@monopole
Copy link
Contributor Author

Yes, quite some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api issues for api module area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v3.8.8
Development

No branches or pull requests
2 participants
@monopole @Shell32-Natsu