Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete WNodeFactory implementation. #2894

Closed
monopole opened this issue Aug 26, 2020 · 0 comments · Fixed by #3257
Closed

Complete WNodeFactory implementation. #2894

monopole opened this issue Aug 26, 2020 · 0 comments · Fixed by #3257
Labels
area/api issues for api module area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@monopole
Copy link
Contributor

monopole commented Aug 26, 2020 •
edited
Loading

In service of #2506, which will permit completion of #1500

The methods to implement are here:
https://github.com/kubernetes-sigs/kustomize/tree/master/api/internal/wrappy/factory.go

For details / rationale, see
https://github.com/kubernetes-sigs/kustomize/blob/master/api/krusty/internal/provider/depprovider.go

The other half of this is #2893
@monopole monopole added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 26, 2020
@monopole monopole mentioned this issue Aug 26, 2020
Closed
@Shell32-Natsu Shell32-Natsu added area/api issues for api module kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/dependency Issues or PRs related to dependency changes labels Oct 21, 2020
This was referenced Nov 14, 2020
Merged
Merged
Merged
@monopole monopole mentioned this issue Nov 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api issues for api module area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Secrets and ConfigMaps with binary data in kyaml monopole/kustomize
2 participants
@monopole @Shell32-Natsu