Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #3536 and #3547 to 0.8 #3551

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

gabesaba
Copy link
Contributor

@gabesaba gabesaba commented Nov 15, 2024

Special notes for your reviewer:

I had to manually reimplement PotentiallyAvailable, as that was introduced with HierarchicalCohorts (0.9)

Does this PR introduce a user-facing change?

Change, and in some scenarios fix, the status message displayed to user when a workload doesn't fit in available capacity.
Determine borrowing more accurately, allowing preempting workloads which fit in nominal quota to schedule faster

@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Nov 15, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 15, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc November 15, 2024 16:50
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit fbe94e6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67377bd8d96b430008d373d1
😎 Deploy Preview https://deploy-preview-3551--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2024
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 55158586a7a73e3b57a1a8f15c5801face122253

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 81b2903 into kubernetes-sigs:release-0.8 Nov 15, 2024
16 checks passed
@gabesaba gabesaba deleted the cherry branch November 15, 2024 17:07
@mimowo
Copy link
Contributor

mimowo commented Nov 18, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 18, 2024

/release-note-edit

Change, and in some scenarios fix, the status message displayed to user when a workload doesn't fit in available capacity.
Determine borrowing more accurately, allowing preempting workloads which fit in nominal quota to schedule faster

It presents better in the release notes without the "-" prefix (as the release notes list adds one already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants