Refactor FlavorAssigner

[gabesaba]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Simplifies FlavorAssigner in preparation for #3405

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Change, and in some scenarios fix, the status message displayed to user when a workload doesn't fit in available capacity.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	e92da7a
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67360e242ff0300008b3345f

[PBundyra]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 3e562b8b4122a6b4751d3fd2e33429fa2c28ae3b

[gabesaba]

/lgtm

thanks for the review!

[PBundyra]

Do we want to set this message even if val <= rQuota.Nominal?

[gabesaba]

We did this (a similar message) before, and I think the message is still relevant/accurate - other quota is being used

[mimowo]

This is actually showing the message is fixed

[mimowo]

/lgtm
/approve
We will be cherry-picking this one probably too.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mimowo]

/release-note-edit

Change, and in some scenarios fix, the status message displayed to user when a workload doesn't fit in available capacity.

proposal

[mimowo]

/kind bug
Due to the inaccurate message as per #3536 (comment).

[mimowo]

/cherry-pick release-0.9

[k8s-infra-cherrypick-robot]

@mimowo: new pull request created: #3549

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mimowo]

/cherry-pick release-0.8

[k8s-infra-cherrypick-robot]

@mimowo: #3536 failed to apply on top of branch "release-0.8":

Applying: Refactor FlavorAssigner
Using index info to reconstruct a base tree...
M	pkg/resources/requests.go
M	pkg/scheduler/flavorassigner/flavorassigner.go
M	pkg/scheduler/flavorassigner/flavorassigner_test.go
M	test/integration/scheduler/fairsharing/fair_sharing_test.go
M	test/integration/scheduler/scheduler_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/integration/scheduler/scheduler_test.go
CONFLICT (content): Merge conflict in test/integration/scheduler/scheduler_test.go
Auto-merging test/integration/scheduler/fairsharing/fair_sharing_test.go
Auto-merging pkg/scheduler/flavorassigner/flavorassigner_test.go
CONFLICT (content): Merge conflict in pkg/scheduler/flavorassigner/flavorassigner_test.go
Auto-merging pkg/scheduler/flavorassigner/flavorassigner.go
CONFLICT (content): Merge conflict in pkg/scheduler/flavorassigner/flavorassigner.go
Auto-merging pkg/resources/requests.go
CONFLICT (content): Merge conflict in pkg/resources/requests.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Refactor FlavorAssigner

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.