Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scale flow and documentation #7610

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Improve scale flow and documentation #7610

merged 2 commits into from
Jun 7, 2021

Conversation

forselli-stratio
Copy link
Contributor

@forselli-stratio forselli-stratio commented May 13, 2021 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR fixes some issues when removing nodes commented in the issue #7569.
I also removed the check confirmation part. I think there is no other task that includes this option and it makes difficult to automate or integrate kubespray with other tools.
I also included some changes to Adding/replacing a node documentation. When adding/removing etcd members, apiserver manifest field --etcd-servers= is not updated, so i think it's important to know this.

Which issue(s) this PR fixes:
#7569

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NO

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @forselli-stratio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi May 13, 2021 10:38
@forselli-stratio forselli-stratio changed the title Improve scale flow Fix scale issues May 13, 2021
@forselli-stratio forselli-stratio changed the title Fix scale issues Remove 'bootstrap-os' role when running remove-node.yml playbookd and improve documentation when scaling control-plane nodes May 13, 2021
@forselli-stratio forselli-stratio changed the title Remove 'bootstrap-os' role when running remove-node.yml playbookd and improve documentation when scaling control-plane nodes Improve scale flow and documentation May 13, 2021
oomichi
oomichi reviewed May 13, 2021
View reviewed changes
docs/nodes.md Outdated
@@ -115,6 +115,10 @@ Even so, running applications should continue to be available.
If you add multiple ectd nodes with one run, you might want to append `-e etcd_retries=10` to increase the amount of retries between each ectd node join.
Otherwise the etcd cluster might still be processing the first join and fail on subsequent nodes. `etcd_retries=10` might work to join 3 new nodes.

### 4) Add the new node to apiserver config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is for ## Adding an etcd node and the previous number is 1.
So here should be 2 instead of 4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thank you!

oomichi
oomichi reviewed May 18, 2021
View reviewed changes
remove-node.yml Show resolved Hide resolved
remove-node.yml Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@oomichi: GitHub didn't allow me to request PR reviews from the following users: chifu1234.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

bootstrap-os role has been implemented since #6154
I am not sure what flatcar means on the pull request.

/cc @chifu1234

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oomichi
Copy link
Contributor

oomichi commented May 18, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2021
@oomichi oomichi mentioned this pull request May 27, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2021
floryut
floryut approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, forselli-stratio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1069b05 into kubernetes-sigs:master Jun 7, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 18, 2021
@forselli-stratio @LuckySB
Improve scale flow and documentation (kubernetes-sigs#7610)
1c7fcbe 
* Improve scale flow

* Add confirmation prompt again
@forselli-stratio forselli-stratio deleted the improve-scale branch February 28, 2022 08:04
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@forselli-stratio @sakuraiyuta
Improve scale flow and documentation (kubernetes-sigs#7610)
e18651e 
* Improve scale flow

* Add confirmation prompt again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liupeng0518 liupeng0518 liupeng0518 left review comments

@oomichi oomichi oomichi left review comments

@floryut floryut floryut approved these changes

@EppO EppO Awaiting requested review from EppO

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@forselli-stratio @k8s-ci-robot @oomichi @liupeng0518 @floryut