Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap-os for remove-node #6154

Merged
merged 1 commit into from
Aug 5, 2020
Merged

bootstrap-os for remove-node #6154

merged 1 commit into from
Aug 5, 2020

Conversation

chifu1234
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
If you try to remove a node on flatcar it will fail, since there is no python intepreter

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 17, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 17, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @chifu1234!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @chifu1234. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO May 17, 2020 21:20
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2020
@k8s-ci-robot
Copy link
Contributor

@chifu1234: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chifu1234
Copy link
Contributor Author

/check-cla

3 similar comments
@chifu1234
Copy link
Contributor Author

/check-cla

@chifu1234
Copy link
Contributor Author

/check-cla

@chifu1234
Copy link
Contributor Author

/check-cla

@floryut
Copy link
Member

floryut commented May 27, 2020

@chifu1234 you need to sign CLA or check what is wrong with it :/
Also can you please rebase master ? CI is now fixed :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 31, 2020
@chifu1234
Copy link
Contributor Author

@floryut done

@floryut
Copy link
Member

floryut commented Jun 4, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2020
@floryut
Copy link
Member

floryut commented Jun 5, 2020

/lgtm
WDYT @LuckySB / @Miouge1 ?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 9, 2020

Needs rebase on latest master to resolve conflict in remove-node.yml

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 11, 2020
@floryut
Copy link
Member

floryut commented Jun 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Aug 5, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chifu1234, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit c3b78c3 into kubernetes-sigs:master Aug 5, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Aug 6, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
4e1e4ba 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (30 commits)
  Minor Ambassador docs updates (kubernetes-sigs#6503)
  Fix cilium strict kube proxy replacement in HA (kubernetes-sigs#6473)
  Upgrade JetStack Cert-Manager to v0.15.2 (kubernetes-sigs#6414)
  Fix E306 in tests/ (kubernetes-sigs#6495)
  Fix E306 in roles/kubernetes (kubernetes-sigs#6500)
  Allows tls verify skip on webhook auth url (kubernetes-sigs#6472)
  Fix E306 in scripts/ (kubernetes-sigs#6496)
  Correct sample inventory to pass yamllint (kubernetes-sigs#6499)
  Option for MetalLB to talk BGP (kubernetes-sigs#6383)
  bootstrap-os for remove-node (kubernetes-sigs#6154)
  Quoted type constraints are deprecated (kubernetes-sigs#6497)
  Update base image to v2.13.3 (kubernetes-sigs#6494)
  Fix Flexvolume mount in Openstack Controller (kubernetes-sigs#6480)
  Remove hvac dependency (kubernetes-sigs#6476)
  Create a PodDisruptionBudget for the Cinder CSI controllerplugin (kubernetes-sigs#6385)
  Upgrade molecule to v3 (kubernetes-sigs#6468)
  Remove workaround for kubeadm upgrade (kubernetes-sigs#6478)
  Update kube-router to 1.0.1 and kube-ovn to 1.3.0 (kubernetes-sigs#6479)
  fix src for audit webhook config yaml (kubernetes-sigs#6470)
  crio: align template crio.conf with upstream (kubernetes-sigs#6432)
  ...
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 10, 2021
@chifu1234 @LuckySB
bootstrap-os for remove-node (kubernetes-sigs#6154)
4b51b77
@oomichi oomichi mentioned this pull request May 18, 2021
Merged
@oomichi oomichi mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chifu1234 @k8s-ci-robot @floryut @Miouge1