Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oomichi to reviewers #6796

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Oct 5, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I'd like to propose to be a reviewer to get involved more into the project and make Kubespray better.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten October 5, 2020 16:09
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Oct 5, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@floryut
Copy link
Member

floryut commented Oct 6, 2020

With pleasure @oomichi ! 🚀
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2994ba3 into kubernetes-sigs:master Oct 6, 2020
@oomichi
Copy link
Contributor Author

oomichi commented Oct 6, 2020

@Miouge1 @floryut Thanks! :-)

tevren added a commit to tevren/kubespray that referenced this pull request Oct 10, 2020
…ster

* 'master' of github.com:kubernetes-sigs/kubespray: (1632 commits)
  Chmod kubeconfig to avoid group-readable (kubernetes-sigs#6800)
  Update bunch of dependencies (kubernetes-sigs#6801)
  If no_proxy_exclude_workers is true, workers will be excluded from the no_proxy variable.  This prevents docker engine restarting when scaling workers. (kubernetes-sigs#6520)
  crio: ensure service is started and enabled (kubernetes-sigs#6753)
  Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798)
  Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745)
  Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785)
  Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786)
  Use v2.14.1 as base image for CI (kubernetes-sigs#6773)
  Add oomichi to reviewers (kubernetes-sigs#6796)
  Update triage/support label references to kind/support (kubernetes-sigs#6792)
  Update kube-router to 1.1.0 (kubernetes-sigs#6793)
  harden reset to work in more cases (kubernetes-sigs#6781)
  Add extra arguments variables for openstack and vsphere cloud controller manager daemonsets (kubernetes-sigs#6783)
  Update cilium with minor fix for CVE (kubernetes-sigs#6784)
  Add `plugins/mitogen` to `.gitignore` (kubernetes-sigs#6774)
  Remove arch from flannel image tag (kubernetes-sigs#6765)
  nginx ingress: fix yaml for multiple nodeselectors (kubernetes-sigs#6768)
  Forgotten debian10 test during nightly tests (kubernetes-sigs#6769)
  ...
erulabs added a commit to kubesail/kubespray that referenced this pull request Oct 13, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  crio: ensure service is started and enabled (kubernetes-sigs#6753)
  Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798)
  Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745)
  Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785)
  Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786)
  Use v2.14.1 as base image for CI (kubernetes-sigs#6773)
  Add oomichi to reviewers (kubernetes-sigs#6796)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@oomichi oomichi deleted the add-oomichi-reviewer branch March 2, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants