Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flannel image tag #6765

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Fix Flannel image tag #6765

merged 1 commit into from
Sep 30, 2020

Conversation

electrocucaracha
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

The 0d0cc8c change creates several
DaemonSets to cover the Flannel CNI installation for different CPU
architectures. This change removes the unnecessary architecture value
from the docker tag value.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This change requires to use CPU architecture like ARM.

Does this PR introduce a user-facing change?:

@electrocucaracha
Remove arch from flannel image tag
1ab02d8 
The 0d0cc8c change creates several
DaemonSets to cover the Flannel CNI installation for different CPU
architectures. This change removes the unnecessary architecture value
from the docker tag value.

Signed-off-by: Victor Morales <v.morales@samsung.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 29, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @electrocucaracha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 29, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2020
@oomichi
Copy link
Contributor

oomichi commented Sep 29, 2020

/cc @oomichi
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2020
@floryut
Copy link
Member

floryut commented Sep 30, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@EppO
Copy link
Contributor

EppO commented Sep 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit a374301 into kubernetes-sigs:master Sep 30, 2020
tevren added a commit to tevren/kubespray that referenced this pull request Oct 10, 2020
@tevren
Merge branch 'master' of github.com:kubernetes-sigs/kubespray into ma…
1880e30 
…ster

* 'master' of github.com:kubernetes-sigs/kubespray: (1632 commits)
  Chmod kubeconfig to avoid group-readable (kubernetes-sigs#6800)
  Update bunch of dependencies (kubernetes-sigs#6801)
  If no_proxy_exclude_workers is true, workers will be excluded from the no_proxy variable.  This prevents docker engine restarting when scaling workers. (kubernetes-sigs#6520)
  crio: ensure service is started and enabled (kubernetes-sigs#6753)
  Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798)
  Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745)
  Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785)
  Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786)
  Use v2.14.1 as base image for CI (kubernetes-sigs#6773)
  Add oomichi to reviewers (kubernetes-sigs#6796)
  Update triage/support label references to kind/support (kubernetes-sigs#6792)
  Update kube-router to 1.1.0 (kubernetes-sigs#6793)
  harden reset to work in more cases (kubernetes-sigs#6781)
  Add extra arguments variables for openstack and vsphere cloud controller manager daemonsets (kubernetes-sigs#6783)
  Update cilium with minor fix for CVE (kubernetes-sigs#6784)
  Add `plugins/mitogen` to `.gitignore` (kubernetes-sigs#6774)
  Remove arch from flannel image tag (kubernetes-sigs#6765)
  nginx ingress: fix yaml for multiple nodeselectors (kubernetes-sigs#6768)
  Forgotten debian10 test during nightly tests (kubernetes-sigs#6769)
  ...
@electrocucaracha electrocucaracha deleted the remove_arch_flannel_tag branch October 15, 2020 21:55
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@electrocucaracha @LuckySB
Remove arch from flannel image tag (kubernetes-sigs#6765)
3bbc542 
The 0d0cc8c change creates several
DaemonSets to cover the Flannel CNI installation for different CPU
architectures. This change removes the unnecessary architecture value
from the docker tag value.

Signed-off-by: Victor Morales <v.morales@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@EppO EppO

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@electrocucaracha @k8s-ci-robot @oomichi @floryut @EppO