Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix azure-cloud-config.j2 JSON syntax #6364

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Fix azure-cloud-config.j2 JSON syntax #6364

merged 1 commit into from
Jul 3, 2020

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Jul 2, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Missing , in the JSON dict

Special notes for your reviewer:
Related to #6321

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut July 2, 2020 14:29
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@floryut
Copy link
Member

floryut commented Jul 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 57eefdd into kubernetes-sigs:master Jul 3, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 4, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
0fc14fe 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Fix azure-cloud-config.j2 JSON syntax (kubernetes-sigs#6364)
  Update MetalLB README.md (kubernetes-sigs#6350)
  Cilium: overwrite auto-detected MTU of underlying network (kubernetes-sigs#6329)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020
@Miouge1 @LuckySB
Fix azure-cloud-config.j2 JSON syntax (kubernetes-sigs#6364)
6406114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@floryut floryut Awaiting requested review from floryut

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Miouge1 @k8s-ci-robot @floryut