Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cilium: overwrite auto-detected MTU of underlying network #6329

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

pasqualet
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Overwrite the auto-detected MTU in Cilium agents.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  1. Set vagrant/config.rb:
$network_plugin = "cilium"
  1. Update inventory/sample/group_vars/k8s-cluster/k8s-net-cilium.yml:
cilium_mtu: 1300
  1. Run vagrant:
vagrant up
  1. Verify the MTU:
for pod in $(kubectl -n kube-system get pods -o name -l k8s-app=cilium); do kubectl -n kube-system exec -it $pod -- cilium debuginfo | grep mtu ; done
mtu:1300
mtu:1300
mtu:1300

Does this PR introduce a user-facing change?:

Support the overwrite of MTU in Cilium agents

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @pasqualet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut June 25, 2020 15:05
@floryut
Copy link
Member

floryut commented Jun 25, 2020

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jul 2, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, pasqualet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4ce970c into kubernetes-sigs:master Jul 2, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 4, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Fix azure-cloud-config.j2 JSON syntax (kubernetes-sigs#6364)
  Update MetalLB README.md (kubernetes-sigs#6350)
  Cilium: overwrite auto-detected MTU of underlying network (kubernetes-sigs#6329)
@floryut floryut mentioned this pull request Aug 14, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants