Terraform/OpenStack: Fix idempotency bug in module.network.openstack_… #5914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…networking_router_interface_v2.k8s[0]
k8s-ci-robot
added
kind/bug
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: holmsten, qvicksilver The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Apr 9, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: (21 commits) Remove hard-coded dependance to docker.service in kubelet.service file (kubernetes-sigs#5917) Update Calico to v3.13.2, Multus to v3.4.1. Add ConfigMap get permission to allow calico-node access to kubeadm config. (kubernetes-sigs#5912) Fix idempotence issue in bootstrap-os (kubernetes-sigs#5916) Terraform/OpenStack: Fix idempotency bug in module.network.openstack_networking_router_interface_v2.k8s[0] (kubernetes-sigs#5914) Add kubernetes 1.18.1 hashes (kubernetes-sigs#5915) Proxy fixes (kubernetes-sigs#5869) Remove 1.16.x flag for tf-ovh_coreos-calico (now 1.17 ready) (kubernetes-sigs#5853) Update docker RHEL/CentOS versions to the latest patch versions available. (kubernetes-sigs#5872) Fix conntrack for opensuse and docker support (kubernetes-sigs#5880) Add crictl 1.18.0 hashes for k8s 1.18 (kubernetes-sigs#5877) fix readonly flexvolume in fcos and coreos (kubernetes-sigs#5885) Fix scaling (kubernetes-sigs#5889) Fix chicken and egg problem with proxy_env not defined on the first … (kubernetes-sigs#5896) make explicit that doc is at kubespray.io (kubernetes-sigs#5878) add local-path-provosioner helper image def (kubernetes-sigs#5817) remove unused kubelet options (kubernetes-sigs#5903) Change docker.io repo to variable and upgrade alb image (kubernetes-sigs#5898) Replace latest tags for csi drivers (kubernetes-sigs#5899) CentOS 8 CI (kubernetes-sigs#5842) Bump requirements.txt versions / remove ansible_python_interpreter hack (kubernetes-sigs#5847) ...
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Apr 18, 2020
…networking_router_interface_v2.k8s[0] (kubernetes-sigs#5914)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…networking_router_interface_v2.k8s[0]
What type of PR is this?
What this PR does / why we need it:
Because I broke idempotency in the network module in #5890
Which issue(s) this PR fixes:
Fixes #5913
Special notes for your reviewer:
Does this PR introduce a user-facing change?: