Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project: update ansible #10020

Closed
wants to merge 17 commits into from
Closed

project: update ansible #10020

wants to merge 17 commits into from

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Apr 24, 2023 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Update ansible related (and tests) dependencies, no longer support two different versions of ansible.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update ansible version to 7.4.0

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrFreezeex
Once this PR has been reviewed and has the lgtm label, please assign luckysb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrFreezeex MrFreezeex marked this pull request as draft April 24, 2023 10:51
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2023
@MrFreezeex MrFreezeex force-pushed the update-ansible branch 3 times, most recently from 1b123d9 to 1d4f4f2 Compare April 24, 2023 12:44
@MrFreezeex
Copy link
Member Author

ansible-lint is complaining for many many reasons after those updates, I will try to find time this week or the next to address those

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2023
@MrFreezeex MrFreezeex force-pushed the update-ansible branch 2 times, most recently from 5846714 to 2c67a57 Compare April 24, 2023 14:53
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 24, 2023
@MrFreezeex MrFreezeex force-pushed the update-ansible branch 6 times, most recently from dd2b1e0 to 0bbb1b7 Compare April 25, 2023 09:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023
@MrFreezeex MrFreezeex force-pushed the update-ansible branch 2 times, most recently from 3529b85 to c5ee48c Compare April 27, 2023 08:13
@MrFreezeex MrFreezeex mentioned this pull request Apr 27, 2023
Merged
@MrFreezeex
Copy link
Member Author

I am splitting this into multiple pr: #10034, #10033 (not created by me), then probably the upgrade of ansible-lint and finally the actual ansible upgrade

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023
@MrFreezeex MrFreezeex mentioned this pull request May 2, 2023
Merged
MrFreezeex added 17 commits May 2, 2023 15:49
@MrFreezeex
project: update ansible dependencies
fd17a45 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
tests: update requirements.txt
f46f559 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
contrib/inventory_builder: fix tox.ini for tox4
dd9102f 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
tests: install aws galaxy collection
353984c 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
ansible-lint: disable various rules after ansible upgrade
b548ea8 
Temporarily disable a bunch of linting action following ansible upgrade.
Those should be taken care of separately.

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: resolve deprecated-module ansible-lint error
fe1b29f 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: resolve no-free-form ansible-lint error
9966fea 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: resolve schema[meta] ansible-lint error
c4f5067 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: resolve schema[playbook] ansible-lint error
624e155 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: resolve schema[tasks] ansible-lint error
a852e2d 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: resolve risky-file-permissions ansible-lint error
29ca52f 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: resolve risky-shell-pipe ansible-lint error
ea960fa 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
multus: fix with_items loop
f18935a 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: remove deprecated warn args
c57a5e2 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
project: use fqcn for non builtin tasks
159af2a 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
molecule: remove linting in molecule to support molecule 5
24ee2aa 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@MrFreezeex
molecule: remove role name check for molecule 5 support
a031c03 
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023
@MrFreezeex MrFreezeex mentioned this pull request May 17, 2023
Closed
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2023
@MrFreezeex MrFreezeex closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin Awaiting requested review from cristicalin

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrFreezeex @k8s-ci-robot