Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Fix kubemark issue & Add document for kubemark test #817

Merged

Conversation

TommyLike
Copy link
Contributor

What this PR does / why we need it:

  1. Fix kubemark issue when testing on GCE
  2. Add document for it.

Release note:

None

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2019
@TommyLike
Copy link
Contributor Author

@k82cn @Rajadeepan please take a look.

@k82cn
Copy link
Contributor

k82cn commented Apr 22, 2019

@Rajadeepan @asifdxtreme , please take a look; we need have benchmark result for each release.

test/kubemark/README.md Outdated Show resolved Hide resolved
@Rajadeepan
Copy link
Contributor

@TommyLike Looks fine.

@k82cn
Copy link
Contributor

k82cn commented Apr 23, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@TommyLike
Copy link
Contributor Author

@k82cn @Rajadeepan need lgtm label.

@k82cn
Copy link
Contributor

k82cn commented Apr 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9745bd2 into kubernetes-retired:master Apr 24, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
…kubemark_issue

Fix kubemark issue & Add document for kubemark test
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
…kubemark_issue

Fix kubemark issue & Add document for kubemark test
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
…kubemark_issue

Fix kubemark issue & Add document for kubemark test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants