Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #366 #367

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Fixes #366 #367

merged 1 commit into from
Oct 25, 2017

Conversation

ffledgling
Copy link
Contributor

  • Add --inmemory-zone flag
  • Implement InMemoryZoneInit function to setup initial zones for
    inmemory provider
  • Make "" the default zone for the inmemory provider instead of
    nil/none when no initial zones are specified
  • Update config/flag parsing tests to accept new flag

- Add `--inmemory-zone flag`
- Implement `InMemoryZoneInit` function to setup initial zones for
  inmemory provider
- Make "" the default zone for the inmemory provider instead of
  nil/none when no initial zones are specified
- Update config/flag parsing tests to accept new flag
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2017
@ideahitme
Copy link

LGTM

@ideahitme ideahitme merged commit 6134fe9 into kubernetes-sigs:master Oct 25, 2017
ffledgling added a commit to ffledgling/external-dns that referenced this pull request Jan 18, 2018
- Add `--inmemory-zone flag`
- Implement `InMemoryZoneInit` function to setup initial zones for
  inmemory provider
- Make "" the default zone for the inmemory provider instead of
  nil/none when no initial zones are specified
- Update config/flag parsing tests to accept new flag
lou-lan pushed a commit to lou-lan/external-dns that referenced this pull request May 11, 2022
* Clean untracked while updating index

* Separate clean from update for clarity

* Merge update and clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants