Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to specify zones for inmemory provider via command line #366

Closed
ffledgling opened this issue Oct 24, 2017 · 0 comments
Closed

Add support to specify zones for inmemory provider via command line #366

ffledgling opened this issue Oct 24, 2017 · 0 comments

Comments

@ffledgling
Copy link
Contributor

Currently, if one runs the inmemory provider in combination with a real source (ingress/services etc), the inmemory provider crashes because it tries to insert a record into an empty zone map.

We should give users the ability to specify initial zones for the inmemory provider to insert records into, or provide a default zone (all-accepting zone) so that the run-time behaviour is more or less in line with other providers.
ffledgling added a commit to ffledgling/external-dns that referenced this issue Oct 24, 2017
@ffledgling
Fixes kubernetes-sigs#366
02dc875 
- Add `--inmemory-zone flag`
- Implement `InMemoryZoneInit` function to setup initial zones for
  inmemory provider
- Make "" the default zone for the inmemory provider instead of
  nil/none when no initial zones are specified
- Update config/flag parsing tests to accept new flag
ffledgling added a commit to ffledgling/external-dns that referenced this issue Jan 18, 2018
@ffledgling
Fixes kubernetes-sigs#366 (kubernetes-sigs#367)
e04c0fa 
- Add `--inmemory-zone flag`
- Implement `InMemoryZoneInit` function to setup initial zones for
  inmemory provider
- Make "" the default zone for the inmemory provider instead of
  nil/none when no initial zones are specified
- Update config/flag parsing tests to accept new flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ffledgling