-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] 🌱 Add area label lookup for prefixes to release notes tool #8825
Conversation
Co-authored-by: Oscar Utbult <oscar.utbult@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want to go to the bother of cherry-picking release notes to older supported branches. Instead I think we should have a make target for generating the release notes and only build from main.
WDYT @g-gaston ?
Yeah, that probably scales better, specially if assume that we are going to keep iterating on the script for a few weeks. It would reduce work and noise. I have been thinking about maybe changing the script a bit to not rely on the local git. I'll give that a try and if it turns to be a dead end, we can always automate the process "build to binary from main -> switch to release branch -> git pull -> generate notes with binary -> switch back to main". In the meantime, as long as everyone is aware of the process, it's not a big issue to copy the file before switching branches. So I vote to close this PR. |
This makes a lot of sense - especially as we're already hitting github for the PR labels. Might have to introduce a /close |
@killianmuldoon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #8780
/assign killianmuldoon