-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add area label lookup for prefixes to release notes tool #8780
🌱 Add area label lookup for prefixes to release notes tool #8780
Conversation
ce2dd3e
to
7b6ab38
Compare
Thanks for putting this together. Looks good to me. |
It's already in the description, click on example 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I like the automatic sorting by area too.
Just one suggestions about using the github library instead of execcing the CLI.
/retest |
/lgtm Let's get this merged and we can continue to iterate as the comms team makes improvements. |
LGTM label has been added. Git tree hash: 73ba93662be74793a05e8daf908f119308ddd754
|
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold @g-gaston can you squash the commits? |
4924ca7
to
e866efa
Compare
Co-authored-by: Oscar Utbult <oscar.utbult@gmail.com>
e866efa
to
7b21bd1
Compare
@killianmuldoon done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 45fa91b6cfa992968f697adf5de220d8dd2aa6a3
|
/assign @sbueringer |
/area release |
/remove-area clusterctl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@killianmuldoon: new pull request created: #8825 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Building on top of @oscr's original PR (all credit to oscar), adding support to handle multiple area labels. I added the changes in a separate commit since the original PR was already reviewed. I'll squash before merge.
Adds support for release notes script to lookup area labels. If found it uses the area tag for prefix. Otherwise it uses
MISSING_AREA
meaning it needs manual update.If multiple area labels are found, it uses
MULTIPLE_AREAS[area1|area2...]
.It also sorts each section alphabetically.
Example
Which issue(s) this PR fixes:
Part of #8263
cc @kubernetes-sigs/cluster-api-release-team